From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/systemd: add fdisk support
Date: Mon, 09 Mar 2020 06:22:15 +0200 [thread overview]
Message-ID: <87tv2yw420.fsf@tarshish> (raw)
In-Reply-To: <20200308231822.38941-1-james.hilliard1@gmail.com>
Hi James,
On Mon, Mar 09 2020, James Hilliard wrote:
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/systemd/systemd.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
> index 22165de2c1..526c749191 100644
> --- a/package/systemd/systemd.mk
> +++ b/package/systemd/systemd.mk
> @@ -125,6 +125,12 @@ else
> SYSTEMD_CONF_OPTS += -Dpam=false
> endif
>
> +ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBFDISK),y)
> +SYSTEMD_CONF_OPTS += -Dfdisk=true
> +else
> +SYSTEMD_CONF_OPTS += -Dfdisk=false
Since BR2_PACKAGE_UTIL_LINUX_BINARIES -> BR2_PACKAGE_UTIL_LINUX_LIBFDISK
is selected, the 'else' part is dead code. I'd rather have
BR2_PACKAGE_SYSTEMD select BR2_PACKAGE_UTIL_LINUX_LIBFDISK directly, and
make -Dfdisk=true unconditional.
baruch
> +endif
> +
> ifeq ($(BR2_PACKAGE_VALGRIND),y)
> SYSTEMD_DEPENDENCIES += valgrind
> SYSTEMD_CONF_OPTS += -Dvalgrind=true
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2020-03-09 4:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 23:18 [Buildroot] [PATCH 1/1] package/systemd: add fdisk support James Hilliard
2020-03-09 4:22 ` Baruch Siach [this message]
2020-04-12 13:47 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tv2yw420.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox