From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/dosfstools: introduce sanitation step during install
Date: Fri, 31 May 2019 00:16:57 +0200 [thread overview]
Message-ID: <87tvdb1tba.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <CAGt4E5uynqGo1Th2PB8Wq3-JKSYbcR+Drc3AuarUPKPivmeYJw@mail.gmail.com> (Markus Mayer's message of "Wed, 29 May 2019 19:49:59 -0700")
>>>>> "Markus" == Markus Mayer <mmayer@broadcom.com> writes:
Hi,
>> However, I'm wondering... dosfstools only installs things in /sbin,
>> /usr/share/man and /usr/share/doc. The latter two get deleted in
>> target-finalize. Wouldn't it be a lot easier then to manually install the
>> programs we need to sbin, instead of installing everything and removing what is
>> not needed?
> I had that first, actually. But then I was thinking that would
> duplicate the install logic (or at least a part of it) in the package
> makefile. It is unlikely, but it could lead to some unexpected
> dependencies between upstream tar-ball and Buildroot makefile after an
> update of dosfstools. But maybe that isn't a big problem or there
> wouldn't be any more of a dependency than with the approach above.
> I'm open to either approach. Does anybody have any thoughts one way or another?
Manually installing the specific binaries we want seems like the
simplest / clearest option to me.
Care to send a patch doing that? Thanks!
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2019-05-30 22:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 18:27 [Buildroot] [PATCH] package/dosfstools: introduce sanitation step during install Markus Mayer
2019-05-29 22:22 ` Arnout Vandecappelle
2019-05-30 2:49 ` Markus Mayer
2019-05-30 22:16 ` Peter Korsgaard [this message]
2019-05-30 23:43 ` Markus Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvdb1tba.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox