Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] ngrep: bump to version 1.47
Date: Tue, 06 Nov 2018 10:54:41 +0100	[thread overview]
Message-ID: <87tvkubkf2.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20181106085910.665564c3@windsurf> (Thomas Petazzoni's message of "Tue, 6 Nov 2018 08:59:10 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > Hello,
 > On Tue, 6 Nov 2018 01:14:48 +0100, Arnout Vandecappelle wrote:

 >> Since we don't really want to pass any flags from Buildroot down to the package
 >> build systems, perhaps we should just set
 >> 
 >> override MAKE := make <jlevel stuff>
 >> 
 >> at the top of package/Makefile.in? I've done a quick test, and it seems to fix
 >> the boa issue at least.
 >> 
 >> This would revert the following commit though:
 >> 
 >> commit 4705b600764c683e934da7db54f7971a3c647e8a
 >> Author: Ulf Samuelsson <ulf.samuelsson@atmel.com>
 >> Date:   Tue Jul 17 14:09:07 2007
 >> 
 >> Ensure we use host 'make', even when building 'make' in buildroot
 >> 
 >> but that doesn't explain why it is not wanted to use the Buildroot-built make...

 > But then it would mean that if you have a build like this:

 > packageA
 > packageB
 > packageC
 > host-make
 > packageD
 > packageE
 > packageF

 > then package{A,B,C} would be built with the system-provided make, and
 > then package{D,E,F} would be built with host-make ? Is this really a
 > desirable situation ?

Well, it sounds better than the breakage we have today.

In general, mixing make versions in recursive invocations seems a bit
icky. I guess we could end up with issues if/when we do toplevel
parallel builds as well if the job control tracking differs between
versions.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2018-11-06  9:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01 13:23 [Buildroot] [PATCH 1/2] ngrep: bump to version 1.47 Fabrice Fontaine
2018-11-01 13:23 ` [Buildroot] [PATCH 2/2] ngrep: add libnet optional dependency Fabrice Fontaine
2018-11-03 21:42 ` [Buildroot] [PATCH 1/2] ngrep: bump to version 1.47 Thomas Petazzoni
2018-11-03 22:01   ` Fabrice Fontaine
2018-11-04 10:19     ` Thomas Petazzoni
2018-11-04 11:04       ` Fabrice Fontaine
2018-11-04 11:28         ` Thomas Petazzoni
2018-11-04 11:34         ` Baruch Siach
2018-11-06  0:14           ` Arnout Vandecappelle
2018-11-06  7:59             ` Thomas Petazzoni
2018-11-06  9:54               ` Peter Korsgaard [this message]
2018-11-06 10:31                 ` Arnout Vandecappelle
2018-11-06 11:18                   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tvkubkf2.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox