Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] core/br2-external: properly report unexpected errors
Date: Fri, 31 Mar 2017 09:10:06 +0200	[thread overview]
Message-ID: <87tw69x6pd.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20170326234415.2192a445@free-electrons.com> (Thomas Petazzoni's message of "Sun, 26 Mar 2017 23:44:15 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > Hello,
 > On Sat, 28 Jan 2017 11:41:32 +0100, Yann E. MORIN wrote:
 >> Unextected error in the br2-external script are properly caught, but
 >> they are not reported properly, and we end up in either of two
 >> situations:
 >> 
 >> - the .br2-external.mk file is not generated, in which case make will
 >> try to find a rule to generate it (because the 'include' directive
 >> tries to generate missing files);
 >> 
 >> - the .br-external.mk file is generated but does not contain the error
 >> variable, and thus the build might not get interrupted.
 >> 
 >> We fix that by using a trap on the pseudo ERR signal, to emit the error
 >> variable on unexpected errors.
 >> 
 >> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 >> ---
 >> support/scripts/br2-external | 3 +++
 >> 1 file changed, 3 insertions(+)

Committed to 2017.02.x, thanks.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2017-03-31  7:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-28 10:41 [Buildroot] [PATCH] core/br2-external: properly report unexpected errors Yann E. MORIN
2017-03-26 21:44 ` Thomas Petazzoni
2017-03-31  7:10   ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tw69x6pd.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox