From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] jsmn: new package
Date: Sat, 28 Jan 2017 14:37:22 +0100 [thread overview]
Message-ID: <87tw8j9ugd.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20170128100442.D3EC581938@busybox.osuosl.org> (Thomas Petazzoni's message of "Sat, 28 Jan 2017 23:03:31 +1300")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> commit: https://git.buildroot.net/buildroot/commit/?id=c8bd91bf8958b9644b9fe1965dd81b19507f0a7f
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> Signed-off-by: David Bachelart <david.bachelart@bbright.com>
> [Thomas:
> - fix license, it's MIT, not BSD
> - use TARGET_CONFIGURE_OPTS instead of manually passing CC and AR
> - use full destination path
> - keep only sha256 hash
> - rewrap Config.in help text]
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
[snip]
> +define JSMN_INSTALL_STAGING_CMDS
> + $(INSTALL) -m 0644 $(@D)/libjsmn.a $(STAGING_DIR)/usr/lib/libjsmn.a
> + $(INSTALL) -m 0644 $(@D)/jsmn.h $(STAGING_DIR)/usr/include/jsmn.h
We normally use install -D to create the destination directories if
needed. I agree that these directories are very likely to be created
already, but for consistency -D would be nice.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2017-01-28 13:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-28 10:03 [Buildroot] [git commit] jsmn: new package Thomas Petazzoni
2017-01-28 13:37 ` Peter Korsgaard [this message]
2017-01-29 13:11 ` Thomas Petazzoni
2017-01-29 21:39 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tw8j9ugd.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox