From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain/external: fix building the wrapper on MIPS
Date: Thu, 27 Nov 2014 22:47:43 +0100 [thread overview]
Message-ID: <87tx1knwn4.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1417025350-18199-1-git-send-email-yann.morin.1998@free.fr> (Yann E. MORIN's message of "Wed, 26 Nov 2014 19:09:10 +0100")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Some crazy folks use MIPS machines as build machines. ;-)
> On MIPS, the only acceptable hash-style is 'sysv', because the MIPS ABI
> defines that the GOT ordering to be the same as the symbols ordering,
> while GNU hash requires symbols to be sorted by their hash.
> Looking at binutils' code, it seems that only MIPS suffers from that
> limitation.
> Currently, we force the toolchain wrapper to be linked with both hash
> styles, which breaks on MIPS.
> So, fix that but singling out MIPS, and use sysv in that case, and both
s/but/by/
Committed, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2014-11-27 21:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 18:09 [Buildroot] [PATCH] toolchain/external: fix building the wrapper on MIPS Yann E. MORIN
2014-11-27 12:15 ` Vicente Olivert Riera
2014-11-27 21:47 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tx1knwn4.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox