Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] luajit: pass LDCONFIG=true to make sure dynamic library links are created
Date: Wed, 26 Feb 2014 23:47:46 +0100	[thread overview]
Message-ID: <87txblbiel.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1393453799-32640-1-git-send-email-thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Wed, 26 Feb 2014 23:29:59 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > To install its shared library, the luajit Makefile does:
 >         cd src && test -f $(FILE_SO) && \
 >           $(INSTALL_X) $(FILE_SO) $(INSTALL_DYN) && \
 >           $(LDCONFIG) $(INSTALL_LIB) && \
 >           $(SYMLINK) $(INSTALL_SONAME) $(INSTALL_SHORT1) && \
 >           $(SYMLINK) $(INSTALL_SONAME) $(INSTALL_SHORT2) || :

 > This means that if ldconfig doesn't work or isn't available on the
 > system, it won't create the libluajit-5.1.so -> libluajit-5.1.so.5.2.0
 > symbolic link.

 > Not having this symbolic link prevents lua-ev from finding the shared
 > version of the luajit library, and it fallbacks to using the
 > libluajit.a static library. However, this static library is not built
 > with -fPIC, so using it within a shared library doesn't work, and
 > leads to build failures on architectures that really do want to have
 > non-fPIC code into a shared library, such as x86-64.

 > By passing LDCONFIG=true during the installation steps of luajit, we
 > ensure that the symbolic links are created, which allows lua-ev to
 > detect the shared library properly, making everybody happy.

 > Investigation conducted with Samuel Martin. Thanks!

 > Fixes:

 >   http://autobuild.buildroot.org/results/41c/41c8bb9cf91a86908a150dae27726136cb56f5b7/

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2014-02-26 22:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-26 22:29 [Buildroot] [PATCH] luajit: pass LDCONFIG=true to make sure dynamic library links are created Thomas Petazzoni
2014-02-26 22:47 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87txblbiel.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox