From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] omniorb: add COS Naming Service
Date: Tue, 12 Nov 2013 23:24:10 +0100 [thread overview]
Message-ID: <87txfh2r91.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <9e8746c1-8e33-4c55-b4e2-b2b1e6181f86@email.android.com> (Thomas De Schampheleire's message of "Tue, 12 Nov 2013 21:54:50 +0100")
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:
Hi,
>> +if BR2_PACKAGE_OMNIORB
>> +
>> +config BR2_PACKAGE_OMNIORB_WITH_SERVICES
>> + bool "COS Naming Service"
>> + default y
>> + help
>> + omniORB COS Naming Service
>> +endif
>> +
>> comment "omniORB needs a toolchain w/ C++"
>> depends on !BR2_INSTALL_LIBSTDCPP
> I think it makes more sense to keep this comment close to the config
> option it applies to, thus moving the new cos option below it. I know
> that many packages do not follow this, but I'm planning on fixing
> that...
Careful, kconfig needs sub options to be directly under the main option,
otherwise they don't get indented correctly in menuconfig, so your
options are either:
- Comment before main option
- Comment after all the sub options
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2013-11-12 22:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 20:31 [Buildroot] [PATCH 1/1] omniorb: add COS Naming Service Matt Weber
2013-11-12 20:54 ` Thomas De Schampheleire
2013-11-12 22:09 ` Matthew Weber
2013-11-12 22:24 ` Peter Korsgaard [this message]
2013-11-12 22:29 ` Matthew Weber
2013-11-13 9:07 ` Thomas De Schampheleire
2013-11-13 9:50 ` Peter Korsgaard
2013-11-13 9:59 ` Thomas De Schampheleire
2013-11-13 14:11 ` Matthew Weber
2013-11-12 21:25 ` Arnout Vandecappelle
2013-11-12 22:27 ` Matthew Weber
2013-11-12 21:54 ` Thomas Petazzoni
2013-11-12 22:41 ` Matthew Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txfh2r91.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox