From: Peter Korsgaard <peter@korsgaard.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/restorecond: fix build with BR2_TIME_BITS_64
Date: Wed, 06 Mar 2024 08:25:42 +0100 [thread overview]
Message-ID: <87v85zyg7d.fsf@48ers.dk> (raw)
In-Reply-To: <20240305134746.1124362-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Tue, 5 Mar 2024 14:47:46 +0100")
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Do not remove _FILE_OFFSET_BITS=64 from CFLAGS and CPPFLAGS to avoid the
> following build failure with BR2_TIME_BITS_64 raised since commit
> 3c427c64726560ea1743282a3fdb78f5b28692eb:
> In file included from /home/fabrice/buildroot/output/host/mips-buildroot-linux-gnu/sysroot/usr/include/features.h:394,
> from /home/fabrice/buildroot/output/host/mips-buildroot-linux-gnu/sysroot/usr/include/fts.h:53,
> from restore.h:6,
> from restore.c:1:
> /home/fabrice/buildroot/output/host/mips-buildroot-linux-gnu/sysroot/usr/include/features-time64.h:26:5: error: #error "_TIME_BITS=64 is allowed only with _FILE_OFFSET_BITS=64"
> 26 | # error "_TIME_BITS=64 is allowed only with _FILE_OFFSET_BITS=64"
> | ^~~~~
> Indeed, this LFS workaround was there since the addititon of the package
> in commit 9d6da7a264a5b36ad641a0d26b3a3d27188d3624 and is only needed to
> fix a build failure with the old codesourcery-arm toolchain from 2014
> which uses glibc < 2.23. as glibc 2.23 was released in February 2016:
> https://sourceware.org/glibc/wiki/Release/2.23, drop this workaround as
> already done for libselinux in commit
> c1fa9bc2f7a4e5481edf4fce5c03dd45862fe72c. A follow-up patch will also
> drop codesourcery-arm toolchain.
> Fixes: 3c427c64726560ea1743282a3fdb78f5b28692eb
> - No autobuilder failures (yet)
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-03-06 7:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 13:47 [Buildroot] [PATCH 1/1] package/restorecond: fix build with BR2_TIME_BITS_64 Fabrice Fontaine
2024-03-06 7:25 ` Peter Korsgaard [this message]
2024-03-20 20:35 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v85zyg7d.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox