Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Angelo Compagnucci <angelo@amarulasolutions.com>
Cc: br015@umbiko.net, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3 1/5] system: adding options for configuring wifi
Date: Sun, 18 Sep 2022 11:57:14 +0200	[thread overview]
Message-ID: <87v8plgg3p.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20220705073206.1442280-2-angelo@amarulasolutions.com> (Angelo Compagnucci's message of "Tue, 5 Jul 2022 09:32:02 +0200")

>>>>> "Angelo" == Angelo Compagnucci <angelo@amarulasolutions.com> writes:

 > These options can be used by packages to configure a wifi card
 > to connect at boot.

 > Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
 > ---
 >  system/Config.in | 15 +++++++++++++++
 >  1 file changed, 15 insertions(+)

 > diff --git a/system/Config.in b/system/Config.in
 > index 888c24ce81..9a5bdb2932 100644
 > --- a/system/Config.in
 > +++ b/system/Config.in
 > @@ -418,6 +418,21 @@ comment "automatic network configuration via DHCP needs ifupdown or busybox or n
 >  	depends on !(BR2_PACKAGE_BUSYBOX || BR2_PACKAGE_IFUPDOWN || \
 >  		BR2_PACKAGE_SYSTEMD_NETWORKD || BR2_PACKAGE_NETIFRC)
 
 > +config BR2_SYSTEM_CONNECT_WIFI
 > +	bool "Connect to a default wifi access point"
 > +	default n

'n' is default, so drop that. This doesn't really do anything unless the
user also configures BR2_SYSTEM_DHCP="wlan0", right?

I must say I am not really convinced. This is only useful for quite
specific setups (E.G. a lot more specific than BR2_SYSTEM_DHCP which we
use in a number of defconfigs) and hard codes a number of things (like
WPA-PSK that may or may not make sense in the future).

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-09-18  9:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-05  7:32 [Buildroot] [PATCH v3 0/5] Configure default wifi through kconfig Angelo Compagnucci
2022-07-05  7:32 ` [Buildroot] [PATCH v3 1/5] system: adding options for configuring wifi Angelo Compagnucci
2022-09-18  9:57   ` Peter Korsgaard [this message]
2022-10-03 15:42     ` Angelo Compagnucci
2022-10-04  9:05       ` Andreas Ziegler
2022-10-04  9:14         ` Angelo Compagnucci
2022-07-05  7:32 ` [Buildroot] [PATCH v3 2/5] package/wpa_supplicant: configure wifi on systemv when enabled Angelo Compagnucci
2022-07-05  7:32 ` [Buildroot] [PATCH v3 3/5] package/wpa_supplicant: configure wifi on systemd " Angelo Compagnucci
2022-09-18 10:00   ` Peter Korsgaard
2022-10-03 15:44     ` Angelo Compagnucci
2022-07-05  7:32 ` [Buildroot] [PATCH v3 4/5] package/ifupdown-scripts: add wifi configuration " Angelo Compagnucci
2022-09-18 10:03   ` Peter Korsgaard
2022-10-03 15:50     ` Angelo Compagnucci
2022-07-05  7:32 ` [Buildroot] [PATCH v3 5/5] package/initscripts: add service to load kernel modules at boot Angelo Compagnucci
2022-09-18 10:10   ` Peter Korsgaard
2022-10-03 15:53     ` Angelo Compagnucci

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8plgg3p.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=angelo@amarulasolutions.com \
    --cc=br015@umbiko.net \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox