From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pkg-download.mk: do not add a trailing slash to <PKG>_SITE
Date: Thu, 05 Apr 2018 08:35:55 +0200 [thread overview]
Message-ID: <87vad6ma7o.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <45c0681b-d3a9-99b0-555b-9dd3d6e305ff@mind.be> (Arnout Vandecappelle's message of "Thu, 5 Apr 2018 00:33:03 +0200")
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
Hi,
>> > ifeq ($(BR2_PRIMARY_SITE_ONLY),)
>> > DOWNLOAD_URIS += \
>> > - -u $($(PKG)_SITE_METHOD)+$(dir $(call qstrip,$(1)))
>> > + -u $($(PKG)_SITE_METHOD)+$(patsubst %/,%,$(dir $(call qstrip,$(1))))
>>
>> Alternatively I *THINK* we can just use $($(PKG)_SITE) here.
> No, the <PKG>_PATCH and <PKG>_EXTRA_DOWNLOADS variables may contain full URLs.
Ahh, yes. It did seem too easy ;)
I'll add a note about this and commit, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2018-04-05 6:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 6:30 [Buildroot] [PATCH] pkg-download.mk: do not add a trailing slash to <PKG>_SITE Peter Korsgaard
2018-04-04 6:40 ` Peter Korsgaard
2018-04-04 22:33 ` Arnout Vandecappelle
2018-04-05 6:35 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vad6ma7o.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox