Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/mcelog: fix legal-info
Date: Wed, 14 Jun 2017 00:11:05 +0200	[thread overview]
Message-ID: <87vanza686.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20170612210449.1f5e4bf9@windsurf.lan> (Thomas Petazzoni's message of "Mon, 12 Jun 2017 21:04:49 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

Hi,

 >> Potentially, it will also help in keeping license string of packages
 >> up-to-date if it gets changed. What do you think ?

 > Yocto/OE also has a hash for license files, specifically to check if
 > the license file is changed.

Exactly. I think it makes sense to do so. We provide legal info, and
besides validating that the license files still exist we don't have any
checks in place to ensure we catch license changes.

 > However, I'm not sure if the .hash file is the appropriate location. In
 > the .hash file, we have the hash of the downloaded files (in the ones
 > in DL_DIR). Hashes for files inside the tarball is a quite different
 > thing.

I don't see it as a big issue. If we want hashes for license files then
they need to be stored somewhere, so storing them together with the
download hashes sounds OK to me.

 > Also, I'm a bit worried about the additional complexity and maintenance
 > burden.

I don't think it will add any significant maintenance burden. The
license files very rarely changes, so normally you don't need to update
them (and when you do you want to get notified of it).

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2017-06-13 22:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-12  4:15 [Buildroot] [PATCH 1/1] package/mcelog: fix legal-info Bernd Kuhls
2017-06-12  8:11 ` Thomas Petazzoni
2017-06-12 17:08 ` Rahul Bedarkar
2017-06-12 19:04   ` Thomas Petazzoni
2017-06-13 16:29     ` Rahul Bedarkar
2017-06-13 22:11     ` Peter Korsgaard [this message]
2017-06-13 22:06   ` Peter Korsgaard
2017-06-18  8:02     ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vanza686.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox