From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] sudo: fix static linking with openldap having openssl support
Date: Mon, 15 May 2017 13:36:56 +0200 [thread overview]
Message-ID: <87vap2jqqv.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20170511130040.26036-1-Vincent.Riera@imgtec.com> (Vicente Olivert Riera's message of "Thu, 11 May 2017 14:00:40 +0100")
>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
> If we are building sudo statically and openldap was linked with openssl,
> then when we link sudo with openldap we need to specify the openssl
> libs, otherwise it will fail with "undefined reference" errors.
> Fixes:
> http://autobuild.buildroot.net/results/ebb/ebbb4c3138b5023a0c8bd938db1932a25ba5b6fb/
> http://autobuild.buildroot.net/results/58e/58ee4fddea85f0c79b26582b04a573258e27eb47/
> http://autobuild.buildroot.net/results/051/05151c4ef7f0b3702a6cd5e6df4888d826a37431/
> http://autobuild.buildroot.net/results/b1d/b1dfae81985daee106700191fcb82387833c2e3f/
> http://autobuild.buildroot.net/results/5b4/5b42e8505856156389d480d0da19f6982cf120d8/
> http://autobuild.buildroot.net/results/30a/30a76190428f902f03bcf54ba9f1f4f4377c6fc9/
> http://autobuild.buildroot.net/results/e8c/e8c6bdc314b9a8d5de303633a3abd7b7e44beb2e/
> http://autobuild.buildroot.net/results/483/4830c69cc6a62080e1516f0d9009c2ba619c23c1/
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> package/sudo/sudo.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
> diff --git a/package/sudo/sudo.mk b/package/sudo/sudo.mk
> index 0fcd740..56f83ea 100644
> --- a/package/sudo/sudo.mk
> +++ b/package/sudo/sudo.mk
> @@ -40,6 +40,13 @@ endif
> ifeq ($(BR2_PACKAGE_OPENLDAP),y)
> SUDO_DEPENDENCIES += openldap
> SUDO_CONF_OPTS += --with-ldap
> +# If we are building sudo statically and openldap was linked with openssl, then
> +# when we link sudo with openldap we need to specify the openssl libs, otherwise
> +# it will fail with "undefined reference" errors.
> +ifeq ($(BR2_STATIC_LIBS)$(BR2_PACKAGE_OPENSSL),yy)
> +SUDO_DEPENDENCIES += host-pkgconf
> +SUDO_CONF_ENV = LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs libssl libcrypto`"
> +endif
Committed to 2017.02.x, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2017-05-15 11:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 13:00 [Buildroot] [PATCH] sudo: fix static linking with openldap having openssl support Vicente Olivert Riera
2017-05-11 15:50 ` Thomas Petazzoni
2017-05-15 11:36 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vap2jqqv.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox