From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ruby: assume we always have finite, isinf and isnan for uClibc
Date: Tue, 07 Feb 2017 11:40:02 +0100 [thread overview]
Message-ID: <87vasmthbx.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20170207094759.45076-1-Vincent.Riera@imgtec.com> (Vicente Olivert Riera's message of "Tue, 7 Feb 2017 09:47:59 +0000")
>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
> uClibc has __finite, __isinf and __isnan, and Ruby's configure script
> checks for finite, isinf and isnan (note the missing leading __).
> Because of the naming difference the checks fail, therefore the symbols
> HAVE_FINITE, HAVE_ISINF and HAVE_ISNAN are not defined.
> Ruby code relies on those symbols in order to define its own version of
> the finite, isinf and isnan functions. Since the symbols haven't been
> defined, those definitions cause conflicts with the already-existing
> functions.
> Fixes:
> http://autobuild.buildroot.net/results/f34/f34dc20749c6f6d12c51eddf3ee6c2ef41d7c13d/
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Committed after extending the description and adding a comment in the
.mk file, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2017-02-07 10:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 9:47 [Buildroot] [PATCH] ruby: assume we always have finite, isinf and isnan for uClibc Vicente Olivert Riera
2017-02-07 10:18 ` Baruch Siach
2017-02-07 11:08 ` Peter Korsgaard
2017-02-07 10:40 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vasmthbx.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox