From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivien Didelot Date: Wed, 20 Apr 2016 09:52:40 -0400 Subject: [Buildroot] [PATCH 2/4] linux-headers: indent custom choices In-Reply-To: <20160420090103.6bb2c824@free-electrons.com> References: <1461099155-30702-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1461099155-30702-3-git-send-email-vivien.didelot@savoirfairelinux.com> <5716B828.2070008@mind.be> <20160420090103.6bb2c824@free-electrons.com> Message-ID: <87vb3cwfo7.fsf@ketchup.mtl.sfl> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi Thomas, Arnout, Thomas Petazzoni writes: > Hello, > > On Wed, 20 Apr 2016 00:58:48 +0200, Arnout Vandecappelle wrote: > >> We currently have 5 choice statements where the contents is indented, and 54 >> where it's not. So I wouldn't say that we usually indent it... > > I agreed. > >> That said, I'm not strictly against indenting choice contents: it's not going >> to be nested any deeper, and the lines are normally not that long. The only >> question is what to do with the help texts, because they would suddenly have to >> be wrapped at 82 characters... > > I prefer to keep things non-indented. Otherwise, to be consistent, we > would also have to indent the config options within a if...endif block, > or within a menuconfig...endmenu. And then suddenly you can have a > choice nested in an if, nested in a menuconfig, and your indentation > goes crazy. > > So, I'd say no. I didn't take a look at other files, but only this one, and wanted to be consistent with the rest of the code where the "Kernel Headers" config entries are indented. But I really don't mind, I'll drop this one ;-) Thanks, -v