From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/2] package/libsoil: fix build using old versions of patch
Date: Sat, 20 Feb 2016 23:26:42 +0100 [thread overview]
Message-ID: <87vb5jc925.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20160125233511.57daa120@free-electrons.com> (Thomas Petazzoni's message of "Mon, 25 Jan 2016 23:35:11 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> Dear Ricardo Martincoski,
> On Sun, 24 Jan 2016 11:19:52 -0200, Ricardo Martincoski wrote:
>> Well-formed patch fails to apply
>> - patch v2.6:
>> Hunk #1 FAILED at 1.
>> Hunk #2 FAILED at 23.
>> - patch v2.6.1:
>> can't find file to patch at input line 11
>> Perhaps you used the wrong -p or --strip option?
>> [snip]
>> No file to patch. Skipping patch.
>> 2 out of 2 hunks ignored
>> Patch failed! Please fix 0001-fix-makefile.patch!
>>
>> Old versions of the tool "patch" cannot handle spaces in filenames.
>> The same does not occur using "patch" v2.7 or any later.
>>
>> Workaround: when a file with space in the name needs to be patched,
>> one or two hooks must be used.
>> A pre-patch or post-extract hook renames the file to replace spaces
>> with underscores.
>> The patch file must be generated using diff between two source-trees
>> that have the file renamed with spaces replaced by underscores.
>> A post-patch hook could rename the file to its original name if needed.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/8ff/8ff91ab8e52000eb34dd8f662520cf1b31490cf5/
>> http://autobuild.buildroot.net/results/ea7/ea77d6b23aca0cb1cf527e6c16ddf5eba957a69c/
>>
>> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
>> Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
>> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Applied, thanks.
I think we should add a comment in the .mk to explain why we're doing
this odd rename. I'll do so now.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2016-02-20 22:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-24 13:19 [Buildroot] [PATCH v3 0/2] fix build using old versions of patch Ricardo Martincoski
2016-01-24 13:19 ` [Buildroot] [PATCH v3 1/2] package/libsoil: " Ricardo Martincoski
2016-01-24 14:31 ` Arnout Vandecappelle
2016-01-25 22:35 ` Thomas Petazzoni
2016-02-20 22:26 ` Peter Korsgaard [this message]
2016-01-24 13:19 ` [Buildroot] [PATCH v3 2/2] docs/manual: patches that change files with spaces in the name Ricardo Martincoski
2016-01-24 16:20 ` Yann E. MORIN
2016-01-24 20:48 ` Ricardo Martincoski
2016-01-24 21:08 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb5jc925.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox