Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v7 3/4] infra: Introduce BR2_HOST_NEEDS_JAVA
Date: Wed, 19 Feb 2014 16:19:19 +0100	[thread overview]
Message-ID: <87vbwbyvt4.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1392680233-24585-4-git-send-email-maxime.hadjinlian@gmail.com> (Maxime Hadjinlian's message of "Tue, 18 Feb 2014 00:37:12 +0100")

>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes:

 > XBMC needs Java on the host in order to build, because it  uses a
 > code-generator which is build in two phases:
 > In the first phase SWIG is used to parse C++ header files that define the API.
 > SWIG outputs an XML file that contains a complete description of the structure
 > of the API.
 > In the second phase, the XML file is ingested by a Groovy (Java) program that
 > then creates C++ code that forms the bridge to the scripting language (Python).

 > The second phase is why we need java on the host.

 > You can learn more at the XBMC's wiki:
 > http://wiki.xbmc.org/index.php?title=Codegeneration#How_it_works

 > In order to check that, this patch introduce this mechanism in
 > dependencies.sh
 > It also defines the variable in Config.in

The commit message is wrapped kind of strange.

 > +++ b/support/dependencies/dependencies.sh
 > @@ -191,6 +191,14 @@ if grep -q ^BR2_PACKAGE_CLASSPATH=y $BR2_CONFIG ; then
 >  	done
 >  fi
 
 > +if grep -q ^BR2_HOST_NEEDS_JAVA=y $BR2_CONFIG ; then
 > +	if ! which java > /dev/null ; then
 > +		echo >&2
 > +		echo "You must install '$prog' on your build machine" >&2

And it should use 'java' instead of '$prog' here.

Committed to next with that fixed, thanks.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2014-02-19 15:19 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-17 23:37 [Buildroot] [PATCH v7 0/4] Introducing XBMC Maxime Hadjinlian
2014-02-17 23:37 ` [Buildroot] [PATCH v7 1/4] sdl: add host version Maxime Hadjinlian
2014-02-18 16:13   ` Thomas Petazzoni
2014-02-18 16:41     ` Maxime Hadjinlian
2014-02-19 15:12   ` Peter Korsgaard
2014-02-17 23:37 ` [Buildroot] [PATCH v7 2/4] sdl_image: " Maxime Hadjinlian
2014-02-18 16:11   ` Thomas Petazzoni
2014-02-19 15:14     ` Peter Korsgaard
2014-02-19 15:14   ` Peter Korsgaard
2014-02-17 23:37 ` [Buildroot] [PATCH v7 3/4] infra: Introduce BR2_HOST_NEEDS_JAVA Maxime Hadjinlian
2014-02-18 16:18   ` Thomas Petazzoni
2014-02-18 16:41     ` Maxime Hadjinlian
2014-02-18 16:44       ` Thomas Petazzoni
2014-02-19 15:19   ` Peter Korsgaard [this message]
2014-02-17 23:37 ` [Buildroot] [PATCH v7 4/4] xbmc: new package Maxime Hadjinlian
2014-02-18 16:38   ` Thomas Petazzoni
2014-02-18 17:02     ` Maxime Hadjinlian
2014-02-18 18:30       ` Martin Bark
2014-02-19  0:14         ` Maxime Hadjinlian
2014-02-18 16:57 ` [Buildroot] [PATCH v7 0/4] Introducing XBMC Martin Bark
2014-02-18 17:03   ` Maxime Hadjinlian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vbwbyvt4.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox