Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] boost: New package added. Version 1.47
Date: Mon, 30 Jan 2012 00:04:18 +0100	[thread overview]
Message-ID: <87vcnuglfx.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <4E96BFD0.2050706@visionsystems.de> (Yegor Yefremov's message of "Thu, 13 Oct 2011 12:39:12 +0200")

>>>>> "Yegor" == Yegor Yefremov <yegor_sub1@visionsystems.de> writes:

 Yegor> Signed-off-by: Allan W. Nielsen <a@awn.dk>
 Yegor> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Committed with minor tweaks, sorry for the slow response.

 Yegor> ---
 Yegor> changes: 
 Yegor> 1. convert GENTARGETS to the latest syntax
 Yegor> 2. add all dependencies in one line
 Yegor>  package/Config.in       |    1 
 Yegor>  package/boost/Config.in |   99 ++++++++++++++++++++++++++++++++++++++++++++++++
 Yegor>  package/boost/boost.mk  |   83 ++++++++++++++++++++++++++++++++++++++++
 Yegor>  3 files changed, 183 insertions(+)
 Yegor>  create mode 100644 package/boost/Config.in
 Yegor>  create mode 100644 package/boost/boost.mk

 Yegor> Index: b/package/Config.in
 Yegor> ===================================================================
 Yegor> --- a/package/Config.in
 Yegor> +++ b/package/Config.in
 Yegor> @@ -346,6 +346,7 @@
 Yegor>  source "package/fftw/Config.in"
 Yegor>  source "package/libargtable2/Config.in"
 Yegor>  source "package/argp-standalone/Config.in"
 Yegor> +source "package/boost/Config.in"
 Yegor>  source "package/libatomic_ops/Config.in"
 Yegor>  source "package/libcap/Config.in"
 Yegor>  source "package/libdaemon/Config.in"
 Yegor> Index: b/package/boost/Config.in
 Yegor> ===================================================================
 Yegor> --- /dev/null
 Yegor> +++ b/package/boost/Config.in
 Yegor> @@ -0,0 +1,99 @@
 Yegor> +config BR2_PACKAGE_BOOST
 Yegor> +	bool "boost"
 Yegor> +	select BR2_PACKAGE_BZIP2
 Yegor> +	select BR2_PACKAGE_ZLIB

You're forgetting a 'depends on BR2_INSTALL_LIBSTCPP'

 Yegor> +	help
 Yegor> +	  A general purpose c++ library

s/c++/C++/

 Yegor> +
 Yegor> +	  http://www.boost.org/
 Yegor> +
 Yegor> +menu "Boost libraries"
 Yegor> +	depends on BR2_PACKAGE_BOOST
 Yegor> +

It makes more sense to put all these options in a
if BR2_PACKAGE_BOOST
..

endif 


 Yegor> +config BR2_PACKAGE_BOOST_MULTITHREADED
 Yegor> +	depends on BR2_PACKAGE_BOOST
 Yegor> +	bool "boost-multithreaded"

Should depend on BR2_TOOLCHAIN_HAS_THREADS

 Yegor> +config BR2_PACKAGE_BOOST_THREAD
 Yegor> +	depends on BR2_PACKAGE_BOOST
 Yegor> +	bool "boost-thread"

This one as well.


-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2012-01-29 23:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-13 10:39 [Buildroot] [PATCH v2] boost: New package added. Version 1.47 Yegor Yefremov
2011-12-08  8:36 ` Yegor Yefremov
2012-01-29 23:04 ` Peter Korsgaard [this message]
2012-01-29 23:43   ` Yegor Yefremov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vcnuglfx.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox