From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] external-toolchain: fix support
Date: Sun, 08 May 2011 21:59:49 +0200 [thread overview]
Message-ID: <87vcxlj74a.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <c066155381297965b19106d4cd05524af58c771c.1304873537.git.thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Sun, 8 May 2011 18:52:27 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> The recent commit adding the external toolchain wrapper has broken the
Thomas> support for external toolchain. The check_arm_eabi, check_cplusplus
Thomas> and check_cross_compiler_exists functions were using TARGET_CC, which
Thomas> points to the toolchain wrapper, but at the moment those functions are
Thomas> called, the wrapper hasn't been generated yet.
Thomas> We fix this by passing to these functions the path to the C or C++
Thomas> compiler they should use for their tests.
Thanks, committed. I don't quite know how I could have forgotten about
them in the commit. I do remember looking them over when I fixed the
ones in ext-tool.mk.
The commit would have been a bit smaller if we simply replaced TARGET_CC
with TOOLCHAIN_EXTERNAL_CC (and same for C++) as we only use these
macros from ex-tool.mk anyway, but ok.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2011-05-08 19:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-08 16:52 [Buildroot] [pull request] Pull request for branch for-2011.05/fix-ext-toolchain-support Thomas Petazzoni
2011-05-08 16:52 ` [Buildroot] [PATCH 1/1] external-toolchain: fix support Thomas Petazzoni
2011-05-08 19:59 ` Peter Korsgaard [this message]
2011-05-09 6:58 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vcxlj74a.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox