From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit master 1/1] ed: bump to version 1.5
Date: Thu, 23 Dec 2010 09:48:17 +0100 [thread overview]
Message-ID: <87vd2kswmm.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20101223082919.0d574cf8@surf> (Thomas Petazzoni's message of "Thu, 23 Dec 2010 08:29:19 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> On Wed, 22 Dec 2010 23:47:28 +0100
Thomas> Peter Korsgaard <jacmet@sunsite.dk> wrote:
>> +ED_VERSION = 1.5
>> +ED_SITE = $(BR2_GNU_MIRROR)/ed
>> +ED_CONF_OPT = CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)" \
>> + LDFLAGS="$(TARGET_LDFLAGS)"
Thomas> Sorry for this late review, but why is this ED_CONF_OPT needed ? We
Thomas> already pass those variables through TARGET_CONFIGURE_OPTS.
Yes, it's a bit tricky. TARGET_CONFIGURE_OPTS are provided in the
environment, and the configure script overrides the variables
(CC=''). It then checks for a CC=<blah> argument and uses that,
otherwise it defaults to 'gcc'.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2010-12-23 8:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-22 22:47 [Buildroot] [git commit master 1/1] ed: bump to version 1.5 Peter Korsgaard
2010-12-23 7:29 ` Thomas Petazzoni
2010-12-23 8:48 ` Peter Korsgaard [this message]
2010-12-23 8:56 ` Thomas Petazzoni
2010-12-23 9:07 ` Peter Korsgaard
2010-12-23 12:04 ` Gustavo Zacarias
2010-12-23 12:47 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vd2kswmm.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox