From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package: don't default to y for categories
Date: Fri, 14 Nov 2008 12:43:01 +0100 [thread overview]
Message-ID: <87vduqo7ne.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20081114111923.4d1f2ab8@hcegtvedt> (Hans-Christian Egtvedt's message of "Fri\, 14 Nov 2008 11\:19\:23 +0100")
>>>>> "Hans-Christian" == Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> writes:
Hi,
>> In our case, the categories ? Graphical libraries ?, ? Audio stuff ?
>> and others do not lead to anything being compiled, except if I'm
>> wrong. So I would say that we shouldn't be able to select/unselect the
>> categories. They should just be submenus, to organize the options, not
>> more.
>>
Hans-Christian> Ah, even more sane. I think I for long time ago
Hans-Christian> (probably fixed now) that LZO was not compiled if the
Hans-Christian> compression menu was not selected. LZO was selected
Hans-Christian> by some other packages in a different sub menu.
I actually think that's still the case as we don't source the
Config.in files of the stuff in the sub menus if the menu isn't
enabled.
>> Look at the top of the kernel configuration system. Networking support
>> can be enabled/disabled as a whole, while Device Drivers is just a
>> submenu. Our categories should be like Device Drivers, IMO.
>>
Hans-Christian> Yes, that is smoother IMHO.
I agree. I'll change the sub menus to use menu / endmenu instead of
menuconfig. This does mean that you no longer can deselect all
packages in a submenu simply by deselecting the menu, but as all
packages default to n that shouldn't be a big deal.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2008-11-14 11:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 19:07 [Buildroot] [PATCH] package: don't default to y for categories Markus Heidelberg
[not found] ` <9060C4F3-5F97-416B-9363-ABF9FFA8E329@valka.is>
2008-11-14 8:57 ` Markus Heidelberg
2008-11-14 9:10 ` Hans-Christian Egtvedt
2008-11-14 9:21 ` Markus Heidelberg
2008-11-14 9:52 ` Hans-Christian Egtvedt
2008-11-14 10:15 ` Thomas Petazzoni
2008-11-14 10:19 ` Hans-Christian Egtvedt
2008-11-14 11:43 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vduqo7ne.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox