From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95B2AC64ED6 for ; Tue, 28 Feb 2023 16:13:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 46F318130B; Tue, 28 Feb 2023 16:13:42 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 46F318130B X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b6jtyhgf5_C4; Tue, 28 Feb 2023 16:13:41 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 09D8F81314; Tue, 28 Feb 2023 16:13:39 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 09D8F81314 Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 581661BF5A8 for ; Tue, 28 Feb 2023 16:12:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id DCE1960585 for ; Tue, 28 Feb 2023 16:12:39 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org DCE1960585 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s0To_5XqBCqv for ; Tue, 28 Feb 2023 16:12:37 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org B948260AD4 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::225]) by smtp3.osuosl.org (Postfix) with ESMTPS id B948260AD4 for ; Tue, 28 Feb 2023 16:12:36 +0000 (UTC) Received: (Authenticated sender: peter@korsgaard.com) by mail.gandi.net (Postfix) with ESMTPSA id 215801C000C; Tue, 28 Feb 2023 16:12:30 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.94.2) (envelope-from ) id 1pX2ac-009sCx-1q; Tue, 28 Feb 2023 17:12:30 +0100 From: Peter Korsgaard To: Arnout Vandecappelle References: <20230208142851.D0048846E3@busybox.osuosl.org> Date: Tue, 28 Feb 2023 17:12:30 +0100 In-Reply-To: <20230208142851.D0048846E3@busybox.osuosl.org> (Arnout Vandecappelle's message of "Wed, 8 Feb 2023 15:28:28 +0100") Message-ID: <87wn41ixap.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Subject: Re: [Buildroot] [git commit] utils/brmake: fix shellcheck errors X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" >>>>> "Arnout" == Arnout Vandecappelle writes: > commit: https://git.buildroot.net/buildroot/commit/?id=dc364c6ae65d3167409380b8883123a55270b18d > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master > In utils/brmake line 6: > local found ret start d h m mf > ^---^ SC2034: found appears unused. Verify use (or export if used externally). > In utils/brmake line 16: >> >( while read line; do > ^--^ SC2162: read without -r will mangle backslashes. > For both, the suggestions from shellcheck can be applied. > Signed-off-by: Arnout Vandecappelle Committed to 2022.11.x and 2022.02.x, thanks. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot