Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] Revert "package/libsoxr: add avutil to soxr.pc"
Date: Mon, 04 Mar 2019 22:36:33 +0100	[thread overview]
Message-ID: <87wolegw4e.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20190222010714.22028-1-joerg.krause@embedded.rocks> ("Jörg Krause"'s message of "Fri, 22 Feb 2019 02:07:13 +0100")

>>>>> "J?rg" == J?rg Krause <joerg.krause@embedded.rocks> writes:

 > This reverts commit d81870ae8129389a62df80c9c8c9165d334b6921.
 > The patch attempts to fix static linking with libsoxr when it build with
 > avutils. The `Libs.private` field should not contain the full absolute path to
 > the static library, but only the link flags for private libraries, e.g
 > `-lm`.

 > Buildroots pkg-config prepends the sysroot to the value found in `Libs.private`
 > resulting in a malformed linker flag if libavutil is found:

 > ```
 > -L/home/test/autobuild/run/instance-3/output/host/bin/../arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib
 > -lsoxr
 > /home/test/autobuild/run/instance-3/output/host/bin/../arm-buildroot-linux-uclibcgnueabi/sysroot/home/test/autobuild/run/instance-3/output/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libavutil.a
 > ```

 > .. or if libavutils is not found:

 > ```
 > -L/home/test/autobuild/run/instance-1/output/host/bin/../arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib
 > -lsoxr AVUTIL_LIBRARIES-NOTFOUND
 > ```

 > Revert this commit and replace the patch by a follow-up patch which only
 > adds `-lavutil` to `Libs.private` in case it is found and used by
 > libsoxr.

 > Fixes:
 > http://autobuild.buildroot.net/results/6eb4e2c9bd3884ab0152ddf873c20e62f0941181/
 > http://autobuild.buildroot.net/results/07207b0a58a08bf7c2cb78345a58244b5e6aab0e/

 > Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>

Committed, thanks.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2019-03-04 21:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22  1:07 [Buildroot] [PATCH 1/2] Revert "package/libsoxr: add avutil to soxr.pc" Jörg Krause
2019-02-22  1:07 ` [Buildroot] [PATCH 2/2] package/libsoxr: add patch to add Libs.private in soxr.pc Jörg Krause
2019-03-04 21:36   ` Peter Korsgaard
2019-03-17 22:16   ` Peter Korsgaard
2019-03-04 21:36 ` Peter Korsgaard [this message]
2019-03-17 22:16 ` [Buildroot] [PATCH 1/2] Revert "package/libsoxr: add avutil to soxr.pc" Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wolegw4e.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox