From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcin =?utf-8?Q?Niestr=C3=B3j?= Date: Fri, 23 Nov 2018 11:12:57 +0100 Subject: [Buildroot] [PATCH] configs/chiliboard: remove explicit getty port In-Reply-To: <66d34c66-c928-e00a-d59a-e09553fc7638@mind.be> References: <20181121210142.21769-1-m.niestroj@grinn-global.com> <66d34c66-c928-e00a-d59a-e09553fc7638@mind.be> Message-ID: <87wop4w192.fsf@grinn-global.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi Arnout, Arnout Vandecappelle writes: > On 21/11/2018 22:01, Marcin Niestroj wrote: >> Using default value (console) works well, so there is no reason to set >> tty explicitly. Additionally after selecting newer kernels (tested >> with 4.19 and 4.20-rc3) ttyO0 no longer works due to missing device >> node. > > Actually, does it still work with the 4.16 kernel? IIRC the ttyO were replaced > by the standard ttyS ages ago (like, 3.18 or something like that). If it doesn't > work with the 4.16 kernel, it should be applied to master. > Yes, it still works with 4.16. There are /dev/ttyS[0-5] and /dev/ttyO0 nodes. In case of 4.19 and 4.20 there is no /dev/ttyO0 anymore, but I did not get into the exact reason what changed. I just checked how other boards configure getty in Buildroot and it turns out most of them leave the default value. > Anyway, > > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) Thanks! Regards, Marcin > > Regards, > Arnout > >> >> Signed-off-by: Marcin Niestroj >> --- >> configs/grinn_chiliboard_defconfig | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/configs/grinn_chiliboard_defconfig b/configs/grinn_chiliboard_defconfig >> index 81d7bae911..84f24e1cc4 100644 >> --- a/configs/grinn_chiliboard_defconfig >> +++ b/configs/grinn_chiliboard_defconfig >> @@ -1,7 +1,6 @@ >> BR2_arm=y >> BR2_cortex_a8=y >> BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_16=y >> -BR2_TARGET_GENERIC_GETTY_PORT="ttyO0" >> BR2_SYSTEM_DHCP="eth0" >> BR2_ROOTFS_POST_IMAGE_SCRIPT="board/grinn/chiliboard/post-image.sh" >> BR2_LINUX_KERNEL=y >>