From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] fs: add missing $$(sep) to pre- and post-command hooks code
Date: Sun, 26 Nov 2017 21:23:58 +0100 [thread overview]
Message-ID: <87wp2chjq9.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20171103184953.32650-1-andrew.smirnov@gmail.com> (Andrey Smirnov's message of "Fri, 3 Nov 2017 11:49:53 -0700")
>>>>> "Andrey" == Andrey Smirnov <andrew.smirnov@gmail.com> writes:
> When multiple hooks are registred, both pre-a and post-command hooks'
> foreach loops need to have a separator at the end in order for the
> code to work as intended. Without the separator all hooks end up as a
> one single line command thus making all but the first hook into
> no-ops.
> Fixes: 4628b6f3b4 ("fs: add pre- and post-command hooks")
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Romain Naour <romain.naour@gmail.com>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Committed to 2017.08.x, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2017-11-26 20:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 18:49 [Buildroot] [PATCH] fs: add missing $$(sep) to pre- and post-command hooks code Andrey Smirnov
2017-11-03 22:08 ` Yann E. MORIN
2017-11-06 21:33 ` Andrey Smirnov
2017-11-05 16:53 ` Arnout Vandecappelle
2017-11-26 20:23 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp2chjq9.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox