From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/ffmpeg: fix static linking with alsa
Date: Tue, 06 Jun 2017 15:26:06 +0200 [thread overview]
Message-ID: <87wp8pcknl.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20170606145122.0b36d3cb@free-electrons.com> (Thomas Petazzoni's message of "Tue, 6 Jun 2017 14:51:22 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Hi,
>> Calling it bogus is imho a bit harsh, but yeah - Getting it fixed
>> upstream so it works without seq would be nicer.
> I think it's bogus because the root of the problem is in alsa-lib, but
> the proposed fix requires to touch potentially all users of alsa-lib.
> So even if we decide not to patch alsa-lib, the proper fix would have
> been:
> config BR2_PACKAGE_ALSA_LIB_RAWMIDI
> bool "rawmidi"
> + BR2_PACKAGE_ALSA_LIB_SEQ
> default y
> Because right now, the library produced by alsa-lib is broken, and this
> is worked around in packages using alsa-lib rather than alsa-lib itself.
True. Will you fix it or do you want me to send a patch?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2017-06-06 13:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 20:39 [Buildroot] [PATCH 1/2] package/ffmpeg: add optional support for alsa-lib Bernd Kuhls
2017-06-01 20:39 ` [Buildroot] [PATCH 2/2] package/ffmpeg: fix static linking with alsa Bernd Kuhls
2017-06-05 12:48 ` Thomas Petazzoni
2017-06-06 12:27 ` Peter Korsgaard
2017-06-06 12:51 ` Thomas Petazzoni
2017-06-06 13:26 ` Peter Korsgaard [this message]
2017-06-06 13:35 ` Thomas Petazzoni
2017-06-06 13:46 ` Peter Korsgaard
2017-06-05 12:42 ` [Buildroot] [PATCH 1/2] package/ffmpeg: add optional support for alsa-lib Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp8pcknl.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox