From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Korsgaard Date: Wed, 17 May 2017 10:57:13 +0200 Subject: [Buildroot] [PATCH] rabbitmq-c: openssl/popt sub-options don't work in stat_ic linking In-Reply-To: <1494796962-24132-1-git-send-email-thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Sun, 14 May 2017 23:22:42 +0200") References: <1494796962-24132-1-git-send-email-thomas.petazzoni@free-electrons.com> Message-ID: <87wp9f6ety.fsf@dell.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net >>>>> "Thomas" == Thomas Petazzoni writes: > rabbitmq-c currently fails to build in a number of static linking > situations, due to two issues: > - CMake FindOpenSSL module is buggy. Even though it uses pkg-config, > it doesn't use the information returned by pkg-config, and > therefore doesn't know about second order libraries that need be > part of the link for static linking to succeed. Due to this, -lz is > not passed, and therefore rabbitmq-c fails when linking against > libssl/libcrypto. This issue has been reported to upstream CMake at > https://gitlab.kitware.com/cmake/cmake/issues/16885. > - popt might use libintl, but CMake doesn't know about that. For > autotools based packages, we typically work around this by passing > LIBS=, but CMake apparently has no equivalent to LIBS=. > To workaround this, we only use the OpenSSL and Popt optional > dependencies in dynamic linking situations. I was hesitating if it wasn't better to just make rabbitmq-c depend on !static, but OK. Committed after fixing subject, thanks. -- Bye, Peter Korsgaard