[Buildroot] [PATCH] package/faketime: fix build with gcc >= 6

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:

Hi,

 >> > +[Romain: rebase on 0.9.6]
 >> > +Signed-off-by: Romain Naour <romain.naour@gmail.com>
 >> 
 >> It is nice if you use the -x option to git cherry-pick so it adds a
 >> comment about the original git commit id. I've now manually added it.

 > Well, sometime I just use git format-patch -1 HASH when the patch apply cleanly
 > without creating a new branch and cherry-picking. In that case there is no -x
 > option...

No, but in that case you are not rebasing, so the git hash listed in the
commit is the correct one. The -x option is only when you rebase /
cherry-pick for traceability.

>>> +---
 >> > + src/Makefile | 2 +-
 >> > + 1 file changed, 1 insertion(+), 1 deletion(-)
 >> > +
 >> > +diff --git a/src/Makefile b/src/Makefile
 >> > +index 51634b0..bbbd476 100644
 >> > +--- a/src/Makefile
 >> > ++++ b/src/Makefile
 >> > +@@ -67,7 +67,7 @@ INSTALL ?= install
 >> > + PREFIX ?= /usr/local
 >> > + LIBDIRNAME ?= /lib/faketime
 >> > + 
 >> > +-CFLAGS += -std=gnu99 -Wall -Wextra -Werror -DFAKE_STAT
 >> > -DFAKE_SLEEP -DFAKE_TIMERS -DFAKE_INTERNAL_CALLS -fPIC
 >> > -DPREFIX='"'$(PREFIX)'"' -DLIBDIRNAME='"'$(LIBDIRNAME)'"'
 >> > ++CFLAGS += -std=gnu99 -Wall -Wextra -Werror -Wno-nonnull-compare
 >> > -DFAKE_STAT -DFAKE_SLEEP -DFAKE_TIMERS -DFAKE_INTERNAL_CALLS
 >> > -fPIC -DPREFIX='"'$(PREFIX)'"' -DLIBDIRNAME='"'$(LIBDIRNAME)'"'
 >> 
 >> The -Wall -Werror flags are not so nice, but oh well.

 > ha yes... do you want I send a new patch removing Werror instead ?

So far we don't seem to have any build failures from it (besides this
one), so it isn't strictly needed - Just a potential problem.

I would leave it as is for now, unless if we can convince upstream to
accept such a patch.

-- 
Bye, Peter Korsgaard