From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] efl/libecore: fix build with gcrypt
Date: Tue, 01 Jan 2013 15:36:31 +0100 [thread overview]
Message-ID: <87wqvxrmvk.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1357046638-2195-1-git-send-email-thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Tue, 1 Jan 2013 14:23:58 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> When building with gnutls, libecore also needs libgcrypt.
Thomas> Fixes:
Thomas> http://autobuild.buildroot.org/results/4da454d6414cf8f4e638defae9b793fb46a0a072/build-end.log
Thomas> While we're at it, also explicit the --enable-openssl /
Thomas> --disable-openssl depending on whether openssl is available or not.
Thomas> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thomas> ---
Thomas> package/efl/libecore/libecore.mk | 8 +++++++-
Thomas> 1 file changed, 7 insertions(+), 1 deletion(-)
Thomas> diff --git a/package/efl/libecore/libecore.mk b/package/efl/libecore/libecore.mk
Thomas> index 0220017..e824bfa 100644
Thomas> --- a/package/efl/libecore/libecore.mk
Thomas> +++ b/package/efl/libecore/libecore.mk
Thomas> @@ -36,10 +36,16 @@ endif
Thomas> ifeq ($(BR2_PACKAGE_OPENSSL),y)
Thomas> LIBECORE_DEPENDENCIES += openssl
Thomas> +LIBECORE_CONF_OPT += --enable-openssl
Thomas> +else
Thomas> +LIBECORE_CONF_OPT += --disable-openssl
Thomas> endif
Thomas> ifeq ($(BR2_PACKAGE_GNUTLS),y)
Thomas> -LIBECORE_DEPENDENCIES += gnutls
Thomas> +LIBECORE_DEPENDENCIES += gnutls libgcrypt
No, we shouldn't pull in dependencies behind the users' back. I've
changed it to only activate when both gnutls and libgcrypt are present.
Committed with that change, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2013-01-01 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-01 13:23 [Buildroot] [PATCH] efl/libecore: fix build with gcrypt Thomas Petazzoni
2013-01-01 14:36 ` Peter Korsgaard [this message]
2013-01-01 14:56 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqvxrmvk.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox