From: Peter Korsgaard <peter@korsgaard.com>
To: Arnout Vandecappelle via buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] package/ntpsec: fix compile issue for some toolchains
Date: Wed, 07 Aug 2024 10:51:00 +0200 [thread overview]
Message-ID: <87y158ogwb.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <fc53aba5-aca9-4fd6-96f1-906708e59b4c@mind.be> (Arnout Vandecappelle via buildroot's message of "Fri, 12 Jul 2024 21:44:14 +0200")
>>>>> "Arnout" == Arnout Vandecappelle via buildroot <buildroot@buildroot.org> writes:
> On 13/08/2023 19:43, Waldemar Brodkorb wrote:
>> Ntpsec unconditionally uses PIE to compile code.
>> This breaks compilation for at least microblaze-uclibc and
>> m68k-uclibc toolchains.
> Also, in Buildroot we anyway have BR2_PIC_PIE to handle this
> appropriately according to toolchain capabilities.
>> It would be better to add a configure option to allow to disable pie
>> support,
>> but this is something for an waf expert.
>> When accepted, should be backported to older releases of Buildroot.
>> Fixes:
>> - http://autobuild.buildroot.net/results/77f/77f4e4065874d022a2ae98d82508242f551e224c
>> - http://autobuild.buildroot.net/results/e45/e45b65f2aa323df075d54ff43b0401b5ac7c6eb5
>> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> Applied to master, thanks.
Committed to 2024.02.x and 2024.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-08-07 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-13 17:43 [Buildroot] [PATCH] package/ntpsec: fix compile issue for some toolchains Waldemar Brodkorb
2024-07-12 19:44 ` Arnout Vandecappelle via buildroot
2024-08-07 8:51 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y158ogwb.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox