Re: [Buildroot] [PATCH v4 2/3] package/libtpms: add host package

[Baruch Siach via buildroot <buildroot@buildroot.org>]

Hi Jarkko,

[ Sorry for the dup again ]

On Tue, May 21 2024, Jarkko Sakkinen wrote:
> On Tue May 21, 2024 at 1:39 PM EEST, Baruch Siach wrote:
>> Hi Jarkko,
>>
>> On Tue, May 21 2024, Jarkko Sakkinen wrote:
>> > diff --git a/package/Config.in b/package/Config.in
>> > index 1b6a5b0dab..30b76349ec 100644
>> > --- a/package/Config.in
>> > +++ b/package/Config.in
>> > @@ -1569,6 +1569,7 @@ menu "Crypto"
>> >  	source "package/libssh/Config.in"
>> >  	source "package/libssh2/Config.in"
>> >  	source "package/libtomcrypt/Config.in"
>> > +	source "package/libtpms/Config.in"
>> >  	source "package/libuecc/Config.in"
>> >  	source "package/libxcrypt/Config.in"
>> >  	source "package/mbedtls/Config.in"
>> > diff --git a/package/libtpms/Config.in b/package/libtpms/Config.in
>> > new file mode 100644
>> > index 0000000000..335a5bc7b6
>> > --- /dev/null
>> > +++ b/package/libtpms/Config.in
>> > @@ -0,0 +1,20 @@
>> > +config BR2_PACKAGE_LIBTPMS
>>
>> You are not adding a target package, right? So this config symbol
>> doesn't do anything.
>
> Ugh, right. Now I need to do a check before I roll out a new version.
>
> I think this is what I should actually do, right (diff below)? Sorry
> learning the process :-)

We usually don't provide config symbols for host packages that are only
used as dependencies of other packages. So the right thing to do is drop
Config.in entirely.

baruch

> diff --git a/package/Config.in b/package/Config.in
> index 30b76349ec..1b6a5b0dab 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1569,7 +1569,6 @@ menu "Crypto"
>         source "package/libssh/Config.in"
>         source "package/libssh2/Config.in"
>         source "package/libtomcrypt/Config.in"
> -       source "package/libtpms/Config.in"
>         source "package/libuecc/Config.in"
>         source "package/libxcrypt/Config.in"
>         source "package/mbedtls/Config.in"
> diff --git a/package/Config.in.host b/package/Config.in.host
> index 0cf9dc3897..4e0dab0504 100644
> --- a/package/Config.in.host
> +++ b/package/Config.in.host
> @@ -57,6 +57,7 @@ menu "Host utilities"
>         source "package/jsmin/Config.in.host"
>         source "package/kmod/Config.in.host"
>         source "package/libp11/Config.in.host"
> +       source "package/libtpms/Config.in.host"
>         source "package/llvm-project/lld/Config.in.host"
>         source "package/lpc3250loader/Config.in.host"
>         source "package/lttng-babeltrace/Config.in.host"
> diff --git a/package/libtpms/Config.in b/package/libtpms/Config.in.host
> similarity index 89%
> rename from package/libtpms/Config.in
> rename to package/libtpms/Config.in.host
> index 335a5bc7b6..7a477d21a7 100644
> --- a/package/libtpms/Config.in
> +++ b/package/libtpms/Config.in.host
> @@ -1,7 +1,5 @@
> -config BR2_PACKAGE_LIBTPMS
> +config BR2_HOST_PACKAGE_LIBTPMS
>         bool "libtpms"
> -       select BR2_PACKAGE_LIBTOOL
> -       select BR2_PACKAGE_OPENSSL
>         help
>           Libtpms is a library that targets the integration of TPM
>           functionality into hypervisors, primarily into Qemu. Libtpms
>
> BR, Jarkko

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot