From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] support/scripts/pkg-stats: fix the status for packages found by guess
Date: Mon, 25 Oct 2021 20:54:50 +0200 [thread overview]
Message-ID: <87y26hue85.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20211008212136.721533-1-thomas.petazzoni@bootlin.com> (Thomas Petazzoni's message of "Fri, 8 Oct 2021 23:21:34 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> The pkg-stats scripts tries to match packages against
> release-monitoring.org in two days:
> - First by using the "Buildroot" distribution registered on
> release-monitoring.org, in which we have added a lot of mappings
> between Buildroot package names and release-monitoring.org package
> names. If there is a match using this distribution, the package
> status is RM_API_STATUS_FOUND_BY_DISTRO, which means that the
> resulting HTML has a "found by distro" statement.
> - Then, if the first solution didn't work, by using the pattern
> matching, as done in the check_package_get_latest_version_by_guess()
> function.
> However, there is a bug in this later case: it sets the package status
> to RM_API_STATUS_FOUND_BY_DISTRO as well, while it should have been
> RM_API_STATUS_FOUND_BY_PATTERN. Due to this bug, in the resulting HTML
> file from a pkg-stats run, all packages are marked as "found by
> distro" even the ones that are "found by guess".
> This commit fixes that by setting the correct package status.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> This should be backported to stable branches of Buildroot.
Committed to 2021.02.x and 2021.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-10-25 18:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 21:21 [Buildroot] [PATCH 1/2] support/scripts/pkg-stats: fix the status for packages found by guess Thomas Petazzoni
2021-10-08 21:21 ` [Buildroot] [PATCH 2/2] support/scripts/pkg-stats: use the new 'stable_versions' field of release-monitoring.org Thomas Petazzoni
2021-10-21 19:14 ` Arnout Vandecappelle
2021-10-21 20:03 ` Thomas Petazzoni
2021-10-25 18:54 ` Peter Korsgaard
2021-10-21 19:09 ` [Buildroot] [PATCH 1/2] support/scripts/pkg-stats: fix the status for packages found by guess Arnout Vandecappelle
2021-10-25 18:54 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y26hue85.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox