Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/ttyd: new package
Date: Tue, 16 Jun 2020 06:54:04 +0300	[thread overview]
Message-ID: <87y2onmzs3.fsf@tarshish> (raw)
In-Reply-To: <20200615183103.476615-1-b.bilas@grinn-global.com>

Hi Bartosz,

On Mon, Jun 15 2020, Bartosz Bilas wrote:
> ttyd is a simple command-line tool for sharing
> terminal over the web.
>
> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
> ---

[snip]

> diff --git a/package/ttyd/Config.in b/package/ttyd/Config.in
> new file mode 100644
> index 0000000000..83f27d9282
> --- /dev/null
> +++ b/package/ttyd/Config.in
> @@ -0,0 +1,20 @@
> +config BR2_PACKAGE_TTYD
> +	bool "ttyd"
> +	depends on !BR2_STATIC_LIBS # libuv
> +	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # libuv
> +	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # libuv
> +	depends on BR2_USE_MMU # libuv
> +	select BR2_PACKAGE_JSON_C
> +	select BR2_PACKAGE_LIBUV
> +	select BR2_PACKAGE_LIBWEBSOCKETS
> +	select BR2_PACKAGE_OPENSSL
> +	select BR2_PACKAGE_ZLIB
> +	help
> +	  ttyd is a simple command-line tool for sharing terminal
> +	  over the web.
> +
> +	  https://github.com/tsl0922/ttyd
> +
> +comment "ttyd needs a toolchain w/ NPTL, dynamic library"
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS \
> +		|| BR2_USE_MMU || BR2_TOOLCHAIN_HAS_SYNC_4

This makes the comment always appear when BR2_USE_MMU is enabled, even
when ttyd is selectable. There should be a separate 'depends on
BR2_USE_MMU' to hide the comment when BR2_USE_MMU is not enabled.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2020-06-16  3:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-15 18:31 [Buildroot] [PATCH] package/ttyd: new package Bartosz Bilas
2020-06-16  3:54 ` Baruch Siach [this message]
2020-06-16 17:17   ` Bartosz Bilas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2onmzs3.fsf@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox