From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] util-linux: Add config switches for some more binaries
Date: Sun, 22 Dec 2013 10:19:45 +0100 [thread overview]
Message-ID: <87y53dfdji.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <8738lnjhx4.fsf@dell.be.48ers.dk> (Peter Korsgaard's message of "Fri, 20 Dec 2013 23:07:03 +0100")
>>>>> "Peter" == Peter Korsgaard <jacmet@uclibc.org> writes:
>>>>> "Paul" == Paul Cercueil <paul@crapouillou.net> writes:
>> Signed-Off-By: Paul Cercueil <paul@crapouillou.net>
> Committed, thanks.
Hmm, we have a number of autobuild failures because of missing libpam:
http://autobuild.buildroot.net/results/df5/df5a4929e5039722d9c1fe1265bbd4f7593c4264/build-end.log
Looking closer, I also see some overlap between the existing "login
utilities" and your patch - E.G. you've added LAST as a seperate option,
but it never does anything as "login utilities" adds an
enable/disable-last afterwards.
I don't have a problem with splitting up login utilities if there's a
need, but then we should imho do it for everything enabled by it (and
add proper Config.in.legacy handling).
Care to take a look and send a patch? Thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2013-12-22 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 1:12 [Buildroot] [PATCH] util-linux: Add config switches for some more binaries Paul Cercueil
2013-12-20 22:07 ` Peter Korsgaard
2013-12-22 9:19 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y53dfdji.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox