From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] openpowerlink: new package
Date: Wed, 02 Oct 2013 23:37:07 +0200 [thread overview]
Message-ID: <87y56bnym4.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <615967893.7359315.1379934549708.JavaMail.root@openwide.fr> (Romain Naour's message of "Mon, 23 Sep 2013 13:09:09 +0200 (CEST)")
>>>>> "R" == Romain Naour <romain.naour@openwide.fr> writes:
Hi,
R> +++ b/package/openpowerlink/Config.in
R> @@ -0,0 +1,107 @@
R> +comment "openpowerlink requires thread support in toolchain"
R> + depends on !BR2_TOOLCHAIN_HAS_THREADS
It also needs C++ support. From CMakeLists.txt:
PROJECT (openPOWERLINK C CXX)
R> +
R> +config BR2_PACKAGE_OPENPOWERLINK
R> + bool "openpowerlink"
R> + depends on BR2_TOOLCHAIN_HAS_THREADS
R> + depends on BR2_i386 || BR2_x86_64
R> + help
Your indentation is wrong. Config.in files should be indented with <tab>
(and help lines with <tab><space><space>).
R> + openPOWERLINK is an Open Source Industrial Ethernet
R> + stack implementing the POWERLINK protocol for Managing Node
R> + (MN, POWERLINK Master) and Controlled Node (CN, POWERLINK Slave).
R> +
R> + It is provided by SYSTEC electronic (http://www.systec-electronic.com),
Too long line, please wrap after 'provided by'.
Besides this, it looks good. I did a quick test build with everything
kept to their default and got:
[100%] Built target powerlink
make[2]: Leaving directory `/home/peko/source/buildroot/output/build/openpowerlink-V1.08.3'
make[1]: Leaving directory `/home/peko/source/buildroot/output/build/openpowerlink-V1.08.3'
>>> openpowerlink V1.08.3 Installing to staging directory
PATH="/home/peko/source/buildroot/output/host/bin:/home/peko/source/buildroot/output/host/usr/bin:/home/peko/source/buildroot/output/host/usr/sbin/:/home/peko/bin:/home/peko/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games:/opt/barco/current/usr/bin:/opt/barco/current/usr/bin" PERLLIB="/home/peko/source/buildroot/output/host/usr/lib/perl" /usr/bin/make -j5 DESTDIR=/home/peko/source/buildroot/output/host/usr/i686-buildroot-linux-uclibc/sysroot install -C /home/peko/source/buildroot/output/build/openpowerlink-V1.08.3/
make[1]: Entering directory `/home/peko/source/buildroot/output/build/openpowerlink-V1.08.3'
make[1]: *** No rule to make target `install'. Stop.
make[1]: Leaving directory `/home/peko/source/buildroot/output/build/openpowerlink-V1.08.3'
make: *** [/home/peko/source/buildroot/output/build/openpowerlink-V1.08.3/.stamp_staging_installed] Error 2
So I guess you're missing something?
Please fix and resubmit, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2013-10-02 21:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1924490682.7359027.1379933482308.JavaMail.root@openwide.fr>
2013-09-23 11:09 ` [Buildroot] [PATCH v2 1/1] openpowerlink: new package Romain Naour
2013-10-02 21:37 ` Peter Korsgaard [this message]
2013-10-04 9:19 ` Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y56bnym4.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox