Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] usbmount: bump to 0.0.21
Date: Thu, 21 Jul 2011 22:39:22 +0200	[thread overview]
Message-ID: <87y5zrz7ut.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <4E26EA44.8080405@visionsystems.de> (Yegor Yefremov's message of "Wed, 20 Jul 2011 16:46:28 +0200")

>>>>> "Yegor" == Yegor Yefremov <yegor_sub1@visionsystems.de> writes:

 Yegor> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
 Yegor> ---
 Yegor>  package/usbmount/usbmount-0.0.14.1.patch |   57 -------------------------------
 Yegor>  package/usbmount/usbmount.mk             |    7 ++-
 Yegor>  2 files changed, 4 insertions(+), 60 deletions(-)

Committed with some changes, thanks.

First of all you forgot to remove the BR2_PACKAGE_UDEV_VOLUME_ID select,
which was the reason for the version bump in the first place.

 Yegor> Index: b/package/usbmount/usbmount.mk
 Yegor> ===================================================================
 Yegor> --- a/package/usbmount/usbmount.mk
 Yegor> +++ b/package/usbmount/usbmount.mk
 Yegor> @@ -3,13 +3,14 @@
 Yegor>  # usbmount
 Yegor>  #
 Yegor>  #############################################################
 Yegor> -USBMOUNT_VERSION=0.0.14.1
 Yegor> +USBMOUNT_VERSION=0.0.21
 Yegor>  USBMOUNT_SOURCE:=usbmount_$(USBMOUNT_VERSION).tar.gz
 Yegor> -USBMOUNT_SITE:=http://usbmount.alioth.debian.org/package/
 Yegor> +USBMOUNT_SITE:=http://ftp.de.debian.org/debian/pool/main/u/usbmount

We have a BR2_DEBIAN_MIRROR setting that should be used.


 Yegor>  USBMOUNT_DEPENDENCIES = udev lockfile-progs
 
 Yegor>  define USBMOUNT_INSTALL_TARGET_CMDS
 Yegor> -	$(INSTALL) -m 0755 -D $(@D)/usbmount $(TARGET_DIR)/sbin/usbmount
 Yegor> +	$(INSTALL) -m 0755 -D $(@D)/usbmount $(TARGET_DIR)/usr/share/usbmount/usbmount
 Yegor> +	$(INSTALL) -m 0644 -D $(@D)/usbmount.rules $(TARGET_DIR)/lib/udev/rules.d

You need to provide the destination file name when you use install -D


 Yegor>  	@if [ ! -f $(TARGET_DIR)/etc/usbmount/usbmount.conf ]; then \
 Yegor>  	        $(INSTALL) -m 0644 -D $(@D)/usbmount.conf $(TARGET_DIR)/etc/usbmount/usbmount.conf; \
 Yegor>  	fi

You forgot to update the uninstall step.

The script uses blkid, which we currently don't have enabled in the
default busybox config. I'll fix that.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2011-07-21 20:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-20 14:46 [Buildroot] [PATCH] usbmount: bump to 0.0.21 Yegor Yefremov
2011-07-21 20:39 ` Peter Korsgaard [this message]
2011-07-21 21:27   ` Yegor Yefremov
2011-07-22 12:10     ` Yegor Yefremov
2011-07-22 12:53       ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y5zrz7ut.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox