Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] svn commit: trunk/buildroot/package/multimedia/alsa-lib
Date: Sat, 31 Jan 2009 13:29:03 +0100	[thread overview]
Message-ID: <87y6wrlkvk.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20090131101825.7DC5376219@busybox.osuosl.org> (ulf@uclibc.org's message of "Sat\, 31 Jan 2009 10\:18\:25 +0000 \(UTC\)")

>>>>> "ulf" == ulf  <ulf@uclibc.org> writes:

 ulf> Author: ulf
 ulf> Date: 2009-01-31 10:18:23 +0000 (Sat, 31 Jan 2009)
 ulf> New Revision: 25175

 ulf> Log:
 ulf> Workaround for AVR32 compiler issue affecting inlining, causing alsa-lib to break, feedback to AVR32 compiler team will be sent

 ulf> +++ trunk/buildroot/package/multimedia/alsa-lib/alsa-lib.mk	2009-01-31 10:18:23 UTC (rev 25175)
 ulf> @@ -12,11 +12,17 @@
 ulf>  ALSA_LIB_TARGET_BINARY:=usr/lib/$(ALSA_LIB_BINARY)
 
 ulf>  ifeq ($(BR2_arm),y)
 ulf> -ALSA_LIB_ABI:=-mabi=aapcs-linux
 ulf> +ALSA_LIB_ABI+=-mabi=aapcs-linux
 ulf>  else
 ulf> -ALSA_LIB_ABI:=
 ulf> +ALSA_LIB_ABI+=
 ulf>  endif
 
 ulf> +ifeq ($(BR2_avr32),y)
 ulf> +ALSA_LIB_ABI+=-DAVR32_INLINE_BUG
 ulf> +else
 ulf> +ALSA_LIB_ABI+=
 ulf> +endif

Please rename that variable to something sensible when you start to
use it for other things, something like ALSA_CFLAGS.

And now we're at it, is the arm abi handling needed after the fix in
r25164? Could you give it a try (with an internal toolchain ofcourse)?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2009-01-31 12:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-31 10:18 [Buildroot] svn commit: trunk/buildroot/package/multimedia/alsa-lib ulf at uclibc.org
2009-01-31 12:29 ` Peter Korsgaard [this message]
2009-02-02  6:09 ` Hans-Christian Egtvedt
2009-02-02  6:34   ` Ulf Samuelsson
2009-02-02  7:59     ` Hans-Christian Egtvedt
  -- strict thread matches above, loose matches on Subject: below --
2009-02-23 13:37 jacmet at uclibc.org
2009-02-23 13:01 jacmet at uclibc.org
2009-02-07  6:57 jacmet at uclibc.org
2009-02-04 23:15 jacmet at uclibc.org
2009-02-01 19:37 jacmet at uclibc.org
2009-01-28 15:33 jacmet at uclibc.org
2009-01-27  5:43 jacmet at uclibc.org
2009-01-12  7:40 ulf at uclibc.org
2009-01-12  7:59 ` Peter Korsgaard
2009-01-11 20:10 ulf at uclibc.org
2008-12-05  9:46 egtvedt at uclibc.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y6wrlkvk.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox