From: Peter Korsgaard <peter@korsgaard.com>
To: Charlie Jenkins <charlie@rivosinc.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/e2fsprogs: Don't build docs for host
Date: Sat, 17 May 2025 22:51:09 +0200 [thread overview]
Message-ID: <87zffb2c76.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20250408-fix_e2fsprogs-v1-1-cc814171907a@rivosinc.com> (Charlie Jenkins's message of "Tue, 08 Apr 2025 17:03:05 -0700")
>>>>> "Charlie" == Charlie Jenkins <charlie@rivosinc.com> writes:
> texinfo isn't provided for the host in buildroot, but e2fsprogs always
> attempts to build the documentation. The error that gets printed is as
> follows:
> /usr/bin/install: cannot stat 'libext2fs.info*': No such file or directory
> make[3]: [Makefile:363: install-doc-libs] Error 1 (ignored)
> This error is ignored but it is unnecessary.
> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
This is presumably not unique to the host version? Given that this is
intentional behaviour from upstream (hence the "ignored"), I don't think
it makes sense to add the extra complexity.
If you would like to get rid of the warning then please work with
upstream to handle it in a cleaner way (E.G. with a configure flag to
disable docs).
> ---
> package/e2fsprogs/e2fsprogs.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
> diff --git a/package/e2fsprogs/e2fsprogs.mk b/package/e2fsprogs/e2fsprogs.mk
> index 7f33b256c2626430a4578a9d8ffd8258df364a43..ad65d5189e75808af011ec87f0bee9d252f53767 100644
> --- a/package/e2fsprogs/e2fsprogs.mk
> +++ b/package/e2fsprogs/e2fsprogs.mk
> @@ -56,6 +56,12 @@ E2FSPROGS_CONF_OPTS = \
> --disable-rpath \
> --enable-symlink-install
> +# docs will fail to build for the host because buildroot doesn't provide texinfo
> +define HOST_E2FSPROGS_REMOVE_DOCS
> + rm -rf $(@D)/doc
> +endef
> +HOST_E2FSPROGS_PRE_INSTALL_HOOKS += HOST_E2FSPROGS_REMOVE_DOCS
> +
> ifeq ($(BR2_PACKAGE_E2FSPROGS_FUSE2FS),y)
> E2FSPROGS_CONF_OPTS += --enable-fuse2fs
> E2FSPROGS_DEPENDENCIES += libfuse
> ---
> base-commit: af094ed137d6967afb6270b69c516a22eb9d8091
> change-id: 20250407-fix_e2fsprogs-68470f22d8cd
> --
> - Charlie
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2025-05-17 20:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 0:03 [Buildroot] [PATCH] package/e2fsprogs: Don't build docs for host Charlie Jenkins
2025-04-19 21:30 ` Thomas Petazzoni via buildroot
2025-05-17 20:51 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zffb2c76.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=charlie@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox