From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEF35C3ABD8 for ; Fri, 16 May 2025 09:35:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 9BDF083B14; Fri, 16 May 2025 09:35:58 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id iMCFs-nwU7f6; Fri, 16 May 2025 09:35:58 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org CF37483C33 Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id CF37483C33; Fri, 16 May 2025 09:35:57 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists1.osuosl.org (Postfix) with ESMTP id 214141AB for ; Fri, 16 May 2025 09:35:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 11ED961267 for ; Fri, 16 May 2025 09:35:57 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id IIHKGLQ-JRhH for ; Fri, 16 May 2025 09:35:56 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=217.70.183.194; helo=relay2-d.mail.gandi.net; envelope-from=peter@korsgaard.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 90D686124D DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 90D686124D Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by smtp3.osuosl.org (Postfix) with ESMTPS id 90D686124D for ; Fri, 16 May 2025 09:35:55 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id A93DB43188; Fri, 16 May 2025 09:35:53 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.96) (envelope-from ) id 1uFrTt-004myy-0d; Fri, 16 May 2025 11:35:53 +0200 From: Peter Korsgaard To: Cherniaev Andrei Cc: buildroot@buildroot.org, Thomas Petazzoni References: <20250515144241.3082079-1-dungeonlords789@naver.com> Date: Fri, 16 May 2025 11:35:53 +0200 In-Reply-To: <20250515144241.3082079-1-dungeonlords789@naver.com> (Cherniaev Andrei's message of "Thu, 15 May 2025 23:42:40 +0900") Message-ID: <87zffcc2yu.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdefuddvgeduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufhfffgjkfgfgggtsehttddttddtredtnecuhfhrohhmpefrvghtvghrucfmohhrshhgrggrrhguuceophgvthgvrheskhhorhhsghgrrghrugdrtghomheqnecuggftrfgrthhtvghrnhepfefgheefledvfffgledujeefiedvjeeigfffteevheekgfejfeevhfeiheehjeeknecuffhomhgrihhnpegsuhhilhgurhhoohhtrdhorhhgnecukfhppedvrgdtvdemkeegvdgrmeeghegrtgemleegtddumeejiegukeemfegvfhhfmehfvggsfeemgegssgehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepvdgrtddvmeekgedvrgemgeehrggtmeelgedtudemjeeiugekmeefvghffhemfhgvsgefmeegsggshedphhgvlhhopeguvghllhdrsggvrdegkegvrhhsrdgukhdpmhgrihhlfhhrohhmpehpvghtvghrsehkohhrshhgrggrrhgurdgtohhmpdhnsggprhgtphhtthhopeefpdhrtghpthhtohepughunhhgvghonhhlohhrughsjeekleesnhgrvhgvrhdrtghomhdprhgtphhtthhopegsuhhilhgurhhoohhtsegsuhhilhgurhhoohhtrdhorhhgpdhrtghpthhtohepthhhohhmrghsrdhpv ghtrgiiiihonhhisegsohhothhlihhnrdgtohhm X-GND-Sasl: peter@korsgaard.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=none (p=none dis=none) header.from=korsgaard.com Subject: Re: [Buildroot] [PATCH] boot/grub2/readme.txt: fix script X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" >>>>> "Cherniaev" == Cherniaev Andrei writes: > Fix regression of commit 552ba600eef0884bb7bf7f09a67cd66747d1efa8 > Without `--show` loop_dev variable will be empty so script never > works... Sorry, it was my mistake... Thanks for the patch. Can you please add your signed-off-by and resend (E.G. git commit --amend -s)? > --- > boot/grub2/readme.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > diff --git a/boot/grub2/readme.txt b/boot/grub2/readme.txt > index d0999ec390..3b7df3a47d 100644 > --- a/boot/grub2/readme.txt > +++ b/boot/grub2/readme.txt > @@ -10,7 +10,7 @@ Notes on using Grub2 for BIOS-based platforms > is enough free space *before* the first partition to > store Grub2. Leaving 1 MB of free space is safe. > 3. Setup loop device and loop partitions > - loop_dev=$(sudo losetup -f disk.img) > + loop_dev=$(sudo losetup -f --show disk.img) > sudo partx -a "$loop_dev" > 4. Prepare the root partition > sudo mkfs.ext3 -L root "${loop_dev}p1" > @@ -65,7 +65,7 @@ Notes on using Grub2 for x86/x86_64 EFI-based platforms > - Create a second partition, type 8300, for the root > filesystem. > 3. Setup loop device and loop partitions > - loop_dev=$(sudo losetup -f disk.img) > + loop_dev=$(sudo losetup -f --show disk.img) > sudo partx -a "$loop_dev" > 4. Prepare the boot partition > sudo mkfs.vfat -n boot "${loop_dev}p1" > -- > 2.45.2 > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot