From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: Matt Silva <dev@matt-silva.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/rlwrap: use the github helper
Date: Thu, 10 Apr 2025 07:07:05 +0300 [thread overview]
Message-ID: <87zfgo8xsm.fsf@tarshish> (raw)
In-Reply-To: <20250410012923.37614-1-dev@matt-silva.com> (Matt Silva's message of "Wed, 9 Apr 2025 21:29:23 -0400")
Hi Matt,
On Wed, Apr 09 2025, Matt Silva wrote:
> Currently, rlwrap just downloads directly from the hardcoded URL to its
> Github releases. However, we have a github helper function to streamline
> this and handle if Github changes its download mechanisms in the future.
>
> Signed-off-by: Matt Silva <dev@matt-silva.com>
> ---
> package/rlwrap/rlwrap.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/rlwrap/rlwrap.mk b/package/rlwrap/rlwrap.mk
> index e3973e841b..3d3d4fab92 100644
> --- a/package/rlwrap/rlwrap.mk
> +++ b/package/rlwrap/rlwrap.mk
> @@ -5,7 +5,7 @@
> ################################################################################
>
> RLWRAP_VERSION = 0.46.1
> -RLWRAP_SITE = https://github.com/hanslub42/rlwrap/releases/download/$(RLWRAP_VERSION)
> +RLWRAP_SITE = $(call github,hanslub42,rlwrap,v$(RLWRAP_VERSION))
We prefer to use release tarball when the package maintainer provides
one. See the relevant section in the Buildroot manual:
https://buildroot.org/downloads/manual/manual.html#github-download-url
baruch
> RLWRAP_LICENSE = GPL-2.0+
> RLWRAP_LICENSE_FILES = AUTHORS COPYING
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2025-04-10 4:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 1:29 [Buildroot] [PATCH 1/1] package/rlwrap: use the github helper Matt Silva
2025-04-10 4:07 ` Baruch Siach via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfgo8xsm.fsf@tarshish \
--to=buildroot@buildroot.org \
--cc=baruch@tkos.co.il \
--cc=dev@matt-silva.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox