From: Peter Korsgaard <peter@korsgaard.com>
To: Julien Olivain <ju.o@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] support/testing: add mdadm runtime test
Date: Tue, 06 Feb 2024 22:06:52 +0100 [thread overview]
Message-ID: <87zfwd480j.fsf@48ers.dk> (raw)
In-Reply-To: <20240127223838.274418-1-ju.o@free.fr> (Julien Olivain's message of "Sat, 27 Jan 2024 23:38:38 +0100")
>>>>> "Julien" == Julien Olivain <ju.o@free.fr> writes:
> Signed-off-by: Julien Olivain <ju.o@free.fr>
> ---
> DEVELOPERS | 2 +
> support/testing/tests/package/test_mdadm.py | 138 ++++++++++++++++++
> .../package/test_mdadm/linux-mdadm.fragment | 3 +
> 3 files changed, 143 insertions(+)
> create mode 100644 support/testing/tests/package/test_mdadm.py
> create mode 100644 support/testing/tests/package/test_mdadm/linux-mdadm.fragment
..
> +
> + # We add back this blank drive to the array.
> + self.assertRunOk(f"mdadm {md_dev} --add {failing_dev}")
> +
> + # We wait few seconds to let the device rebuild.
> + time.sleep(3)
> +
> + # The array should no longer be marked as degraded.
> + out, ret = self.emulator.run(monitor_cmd)
> + self.assertEqual(ret, 0)
> + self.assertNotIn("DegradedArray", "\n".join(out))
That hard coded 3s is likely to cause problems on gitlab as the runners
can be quite slow. How about reworking this to to check every few
seconds for up to E.G. 30s if it has gotten out of the DegradedArray
state?
That can be done later though - So committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-02-06 21:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-27 22:38 [Buildroot] [PATCH 1/1] support/testing: add mdadm runtime test Julien Olivain
2024-02-06 21:06 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfwd480j.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=ju.o@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox