Re: [Buildroot] [PATCH v6 2/3] package/cairo: move to the meson build system

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "Thomas" == Thomas Devoogdt <thomas@devoogdt.com> writes:

 > Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
 > ---
 > v2: added -std=gnu11 (allow inline int declaration in if loop, 99
 > caused some directives problems)
 > v3: enabled host-zlib, needed for librsvg
 > v4: also added gnu11 for host-cairo compiling (fixes my compilation on
 > a gcc 4.9.2 based system)
 > v5: split in 3 commits: https://lore.kernel.org/buildroot/20240105101105.6a181dcd@windsurf/
 > v6: fix host-zlib option (again)
 > ---
 >  package/cairo/Config.in |  34 ++++----
 >  package/cairo/cairo.mk  | 168 ++++++++++++----------------------------
 >  2 files changed, 66 insertions(+), 136 deletions(-)

 > diff --git a/package/cairo/Config.in b/package/cairo/Config.in
 > index 0c87a2904b..caa6c37195 100644
 > --- a/package/cairo/Config.in
 > +++ b/package/cairo/Config.in
 > @@ -4,6 +4,7 @@ config BR2_PACKAGE_CAIRO
 >  	select BR2_PACKAGE_FONTCONFIG
 >  	select BR2_PACKAGE_XLIB_LIBX11 if BR2_PACKAGE_XORG7
 >  	select BR2_PACKAGE_XLIB_LIBXEXT if BR2_PACKAGE_XORG7
 > +	select BR2_PACKAGE_XLIB_LIBXRANDR if BR2_PACKAGE_XORG7

How come the change of build system adds libxrandr? This needs to be
described in the commit message.


>  	help
 >  	  Cairo is a 2D graphics library with support for multiple
 >  	  output devices. Currently supported output targets include
 > @@ -15,34 +16,35 @@ config BR2_PACKAGE_CAIRO
 
 >  if BR2_PACKAGE_CAIRO
 
 > -config BR2_PACKAGE_CAIRO_PS
 > -	bool "postscript support"
 > -	select BR2_PACKAGE_ZLIB
 > -	select BR2_PACKAGE_CAIRO_PDF
 > -
 > -config BR2_PACKAGE_CAIRO_PDF
 > -	bool "pdf support"
 > -	select BR2_PACKAGE_ZLIB

Please don't move options around. They were indeed not alphabetically
sorted, but after your move it is even worse. You are also changing a
number of dependencies without any clear (to me) reason?

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot