From: Peter Korsgaard <peter@korsgaard.com>
To: Mathieu Mirmont via buildroot <buildroot@buildroot.org>
Cc: Mathieu Mirmont <mat@parad0x.org>
Subject: Re: [Buildroot] [PATCH 1/1] fs/common.mk: use find instead of shell glob patterns
Date: Sat, 19 Mar 2022 20:01:03 +0100 [thread overview]
Message-ID: <87zgllpy1c.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20220310101826.GA2353@parad0x.org> (Mathieu Mirmont via buildroot's message of "Thu, 10 Mar 2022 11:18:26 +0100")
>>>>> "Mathieu" == Mathieu Mirmont via buildroot <buildroot@buildroot.org> writes:
> Different shells can have different behaviours when it comes to
> globbing patterns. The dash shell (/bin/sh) on Debian testing switched
> to a different fnmatch/glob implementation that results in this new
> behaviour:
> Using bash:
> $ mkdir /tmp/foo
> $ echo /tmp/foo/.[^.]*
> /tmp/foo/.[^.]*
> Using dash:
> $ mkdir /tmp/foo
> $ echo /tmp/foo/.[^.]*
> /tmp/foo/..
> The current FAKEROOT script uses this shell glob pattern which now
> fails on recent Debian testing systems:
> rm: refusing to remove '.' or '..' directory: skipping '/build/buildroot-fs/cpio/target/run/..'
> rm: refusing to remove '.' or '..' directory: skipping '/build/buildroot-fs/cpio/target/tmp/..'
> It seems safer to use `find | xargs rm` here instead of relying on
> shell globbing patterns.
> Signed-off-by: Mathieu Mirmont <mat@parad0x.org>
Committed to 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-03-19 19:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 10:18 [Buildroot] [PATCH 1/1] fs/common.mk: use find instead of shell glob patterns Mathieu Mirmont via buildroot
2022-03-10 10:45 ` David Laight
2022-03-10 11:33 ` Mat via buildroot
2022-03-10 11:52 ` David Laight
2022-03-10 12:11 ` Mathieu Mirmont via buildroot
2022-03-10 13:47 ` David Laight
2022-03-10 15:42 ` Mathieu Mirmont via buildroot
2022-03-10 11:22 ` Edgar Bonet
2022-03-10 11:31 ` David Laight
2022-03-10 12:02 ` [Buildroot] [PATCH v2] fs/common.mk: fix the globing pattern Mathieu Mirmont via buildroot
2022-03-12 16:19 ` Yann E. MORIN
2022-03-12 16:52 ` [Buildroot] [PATCH 1/1] fs/common.mk: use find instead of shell glob patterns Yann E. MORIN
2022-03-19 19:01 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgllpy1c.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=mat@parad0x.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox