Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 4/9] configs/qemu{x86, x86_64}: add a serial console
Date: Sun, 16 Feb 2020 22:28:27 +0100	[thread overview]
Message-ID: <87zhdicjd0.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20200209180327.455426-5-romain.naour@smile.fr> (Romain Naour's message of "Sun, 9 Feb 2020 19:03:22 +0100")

>>>>> "Romain" == Romain Naour <romain.naour@smile.fr> writes:

 > The current Buildroot defconfigs for qemu_x86 and qemu_x86_64
 > instantiate a console on tty1, which appears on QEMU's
 > graphical window. Add a console on the serial port (ttyS0) to
 > be used later for gitlab testing.

 > This change is need since the script used for gitlab testing
 > needs to use a serial output with pexpect.

 > This change is similar to the one made for raspberrypi [1] to
 > handle HDMI and serial console:

 > This requires three changes:
 >  1. have two 'console=' entries in the kernel command line: tty1,
 >     then ttyS0;
 >  2. change BR2_TARGET_GENERIC_GETTY_PORT to "console", so it starts
 >     a getty on the last console= passed to the kernel, ttyS0;
 >  3. add a new getty on tty1 to the generated inittab.

 > Step 2 is actually obtained by removing BR2_TARGET_GENERIC_GETTY_PORT
 > entirely from the defconfigs, since "console" is the default value.

 > Step 3 requires a post-build script since the Buildroot makefiles can
 > configure only one console.

 > Note: instead of simply adding a new getty on ttyS0 (which would
 > work) this patch actually changes BR2_TARGET_GENERIC_GETTY_PORT to
 > instantiate a console on UART, then adds back tty1 via
 > post-build.sh. This is done only to avoid the "GENERIC_SERIAL" comment
 > where we instantiate a console on QEMU graphical window, then
 > instantiate a really-serial console on another line.

 > The result is these two inittab lines:

 >   console::respawn:/sbin/getty -L  console 0 vt100 # GENERIC_SERIAL
 >   tty1::respawn:/sbin/getty -L  tty1 0 vt100 # QEMU graphical window

 > [1] 20878a1017e2bf7eb8c5f870dc6d2641493cb0f9

 > Signed-off-by: Romain Naour <romain.naour@smile.fr>

Committed, thanks.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2020-02-16 21:28 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-09 18:03 [Buildroot] [PATCH v4 0/9] gitlab Qemu runtime testing Romain Naour
2020-02-09 18:03 ` [Buildroot] [PATCH v4 1/9] configs/qemu_ppc_mac99_defconfig: add usual comments for Kconfig symbols Romain Naour
2020-02-10  2:32   ` Joel Stanley
2020-02-16 21:22   ` Peter Korsgaard
2020-02-09 18:03 ` [Buildroot] [PATCH v4 2/9] configs/qemu_pcc_mac99: build host-qemu for runtime testing Romain Naour
2020-02-10  2:31   ` Joel Stanley
2020-02-16 21:23   ` Peter Korsgaard
2020-02-09 18:03 ` [Buildroot] [PATCH v4 3/9] configs/qemu_m68k_q800: remove host-qemu Romain Naour
2020-02-09 18:12   ` Romain Naour
2020-02-09 18:49     ` Romain Naour
2020-02-16 21:24       ` Peter Korsgaard
2020-02-09 18:03 ` [Buildroot] [PATCH v4 4/9] configs/qemu{x86, x86_64}: add a serial console Romain Naour
2020-02-16 21:28   ` Peter Korsgaard [this message]
2020-02-09 18:03 ` [Buildroot] [PATCH v4 5/9] board/qemu: add defconfig file name as tag before the qemu command line Romain Naour
2020-02-10 13:08   ` Thomas Petazzoni
2020-02-10 13:37     ` Romain Naour
2020-02-10 14:40       ` Thomas Petazzoni
2020-02-09 18:03 ` [Buildroot] [PATCH v4 6/9] board/qemu: add post-image script for gitlab qemu testing Romain Naour
2020-02-10 13:09   ` Thomas Petazzoni
2020-02-10 13:47     ` Romain Naour
2020-02-10 14:41       ` Thomas Petazzoni
2020-02-10 13:13   ` Thomas Petazzoni
2020-02-10 13:49     ` Romain Naour
2020-02-09 18:03 ` [Buildroot] [PATCH v4 7/9] configs/qemu*: use the post-image script with "$(BR2_DEFCONFIG)" as argument Romain Naour
2020-02-09 18:03 ` [Buildroot] [PATCH v4 8/9] support/scripts/boot-qemu-image.py: boot Qemu images with Qemu-system Romain Naour
2020-02-09 18:03 ` [Buildroot] [PATCH v4 9/9] gitlab.yml.in*: enable Qemu gitlab testing Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhdicjd0.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox