From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [2018.02.x 1/2] makedevs: allow leading whitespace for capabilities
Date: Fri, 10 Aug 2018 08:29:07 +0200 [thread overview]
Message-ID: <87zhxuenv0.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <5b6cf5f93b22_57833f926e0c8bdc217d4@ultri5.mail> (Ricardo Martincoski's message of "Thu, 09 Aug 2018 23:18:33 -0300")
>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:
> Hello,
> On Thu, Aug 09, 2018 at 06:42 PM, Thomas Petazzoni wrote:
>> On Mon, 6 Aug 2018 00:17:14 -0300, Ricardo Martincoski wrote:
>>> Currently makedevs silently ignores extended attributes with leading
>>> whitespace, for example those added to a <PACKAGE>_PERMISSIONS following
>>> the recommended style from check-package.
>>>
>>> Makedevs already ignores leading whitespace for normal entries (file
>>> permission changes and device files creation). Do the same for extended
>>> attributes.
>>>
>>> Fixes: #11191.
>>>
>>> Reported-by: Jean-pierre Cartal <jpcartal@free.fr>
>>> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
>>> Cc: Arnout Vandecappelle <arnout@mind.be>
>>> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>>
>> It is not clear to me why you have the "2018.02.x" prefix in your patch
>> title. I would assume this patch is needed in master, not just in
>> 2018.02.x. We generally include 2018.02.x in the patch title when
>> the patch should only be applied to 2018.02.x. For patches going in
>> master, and needing a backport, we normally rely on Peter being smart
>> and realizing that the patch is a fix that makes sense for 2018.02.x.
>>
>> Could you clarify what was your intention with this 2018.02.x prefix ?
> I developed and runtime tested the patch for 2018.02.x.
> But now I tested the patch (by temporarily adding a printf to makedevs) in the
> master branch too. It works well.
> This patch can/should be applied to master.
> In the branch 2018.02.x this patch unbreaks xattr with leading whitespace.
> In the master branch (and also 2018.05.x), which use a per-fs target dir, there
> are other issues with xattr, this patch is only part of the solution to unbreak
> xattrs, see #11216.
Ok, thanks.
Committed to master, and then backported to 2018.02.x and 2018.05.x, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2018-08-10 6:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 3:17 [Buildroot] [2018.02.x 1/2] makedevs: allow leading whitespace for capabilities Ricardo Martincoski
2018-08-06 3:17 ` [Buildroot] [2018.02.x 2/2] support/testing: add test for file capabilities Ricardo Martincoski
2018-08-10 2:21 ` Ricardo Martincoski
2018-08-10 6:32 ` Peter Korsgaard
2018-08-09 21:42 ` [Buildroot] [2018.02.x 1/2] makedevs: allow leading whitespace for capabilities Thomas Petazzoni
2018-08-10 2:18 ` Ricardo Martincoski
2018-08-10 6:29 ` Peter Korsgaard [this message]
2018-08-10 6:28 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhxuenv0.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox