From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] btrfs-progs: adjust install-static patch to install headers under $(prefix)/include/btrfs
Date: Thu, 19 Jul 2018 12:16:31 +0200 [thread overview]
Message-ID: <87zhyncyyo.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20180719104200.39029242@windsurf> (Thomas Petazzoni's message of "Thu, 19 Jul 2018 10:42:00 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> Hello Peter,
> On Sun, 1 Jul 2018 20:34:08 +0200, Peter Korsgaard wrote:
>> Fixes:
>> http://autobuild.buildroot.net/results/15cc6523a42bf66508b2b37fd1fcb74625561ec2/
>>
>> btrfs-progs 'make install' installs headers under $(prefix)/include/btrfs,
>> but our patch to also install headers for 'install-static' installed
>> directly into $(prefix)/include, confusing other packages as btrfs-progs
>> headers have very common names such as version, sizes.h, list.h, ioctl.h, ..
>>
>> Fix it by adjusting the patch to also install under $(prefix)/include/btrfs.
>>
>> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> Could you backport this patch to 2018.05.x. Indeed, the version.h
> installed by btrfs-progs confuses the U-Boot build system, which is the
> reason for the following build failures:
> http://autobuild.buildroot.net/?reason=uboot-tools%&branch=2018.05.x
> The problem doesn't seem to exist on 2018.02.x, because back then, the
> btrfs-progs version was older and was not installing those headers in
> bogus locations. At least the specific uboot-tools problem cannot be
> reproduced on 2018.02.x.
Sure, backported to 2018.05.x. Thanks for the heads up!
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2018-07-19 10:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-01 18:34 [Buildroot] [PATCH] btrfs-progs: adjust install-static patch to install headers under $(prefix)/include/btrfs Peter Korsgaard
2018-07-02 21:07 ` Thomas Petazzoni
2018-07-19 8:42 ` Thomas Petazzoni
2018-07-19 10:16 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhyncyyo.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox