From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] busybox: disable PAM in the config if linux-pam is not selected
Date: Sat, 07 Apr 2018 17:38:53 +0200 [thread overview]
Message-ID: <87zi2ff2lu.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20180326120006.24104-1-arnout@mind.be> (Arnout Vandecappelle's message of "Mon, 26 Mar 2018 14:00:06 +0200")
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:
> Currently there is only logic to enable PAM when linux-pam is selected.
> However, busybox will fail to build with PAM enabled if the linux-pam
> package has not been built before. So we should forcibly disable PAM in
> busybox in that case.
> Normally this is not an issue since our default busybox config doesn't
> have PAM enabled. However, if you enable linux-pam, then save the
> busybox config to a custom configuration file, then disable linux-pam
> again, and then do a "make clean; make", the build will fail. A more
> practical situation where this can occur is when the same custom
> busybox config is used in a Buildroot config with and without
> linux-pam.
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> Resend, patchwork missed the first send.
Committed to 2018.02.x, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2018-04-07 15:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 12:00 [Buildroot] [PATCH] busybox: disable PAM in the config if linux-pam is not selected Arnout Vandecappelle
2018-03-26 12:49 ` Matthew Weber
2018-03-26 12:51 ` Peter Korsgaard
2018-04-07 15:38 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi2ff2lu.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox