From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] linux-firmware hash mismatch (tar-1.30)
Date: Thu, 18 Jan 2018 22:40:25 +0100 [thread overview]
Message-ID: <87zi5adewm.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <ef492963-bf3b-3fbb-f5b1-bba0126f3884@mind.be> (Arnout Vandecappelle's message of "Thu, 18 Jan 2018 00:28:36 +0100")
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
Hi,
>>>> Gaah, what a mess :/
> Note that this also means our github hashes will break again...
Indeed, I also mentioned that earlier.
>> Alas, this means that we can only depend on building our own tar...
> Nah, let's not go there.
>> Even when we eventually support using a local git-clone cache, this we
>> not solve the issue has the hashes we store are on the generated
>> tarball...
> However, the way we create a git tarball can serve as a source of inspiration
> of how to solve it. Instead of hashing the tarball, we can hash the contents of
> the tarball instead, using --to-command and a support script (--to-command
> exists since 1.15.90 and our minimal tar version is 1.17). The support script
> would print the metadata and a hash of the contents. And the output of all that
> is piped into sort (to make sure the order of files in the tarball isn't
> relevant) and shasum.
Hmm, that is perhaps an option. It does make it somewhat more cumbersome
to calculate the expected hash by hand, but maybe that is ok.
Alternatively we don't do anything and instead ensure that tarballs on
s.b.o matches the hashes we commit, and people using incompatible tar
versions will fall back to the tarballs on s.b.o.
> That way we don't rely on the way the user's tar behaves at all. We really
> check the contents of the tarball. It would also mean we can drop the complexity
> in the git download helper and directly use git archive.
I thought the main reason for our custom tarball handling was support
for git submodules? I take it that git-archive still doesn't handle those?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2018-01-18 21:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 16:15 [Buildroot] linux-firmware hash mismatch (tar-1.30) John Keeping
2018-01-10 19:15 ` Peter Korsgaard
2018-01-11 10:55 ` John Keeping
2018-01-14 13:30 ` Yann E. MORIN
2018-01-17 23:28 ` Arnout Vandecappelle
2018-01-18 21:40 ` Peter Korsgaard [this message]
2018-01-22 22:14 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi5adewm.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox