Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] SVN process started at make
Date: Wed, 04 Sep 2013 11:15:27 +0200	[thread overview]
Message-ID: <87zjrt3q34.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <15AE5A936F5E3A42A9144E66875A0A8934DB3F@server1-derijp.CLB-Benelux.lokaal> (Ruud Commandeur's message of "Wed, 4 Sep 2013 10:57:33 +0200")

>>>>> "Ruud" == Ruud Commandeur <RCommandeur@clb.nl> writes:

 Ruud> Dear Thomas,
 Ruud> Well, I did take a quick look at this file, but could have seen this
 Ruud> myself indeed :-)

 Ruud> So it runs an "svn info" and "svn status". This last command can take
 Ruud> quite some time for a large repository, so this explains the delay.

Ok, I'm afraid there's not much to do about svn being crap :/

How come you are only seeing this now? We've been calling
setlocalversion since 2010. Did you recently upgrade your svn version?

Looking at the kernel history (where setlocalversion comes from), I see
a commit from Mike Frysinger where the svn status step is skipped as it
was deemed too slow, so perhaps we should just resync our
setlocalversion script with the kernel:

Author: Mike Frysinger <vapier.adi@gmail.com>
Date:   Thu Feb 5 16:13:32 2009 +0800

    kbuild,setlocalversion: shorten the make time when using svn
    
    Don't bother doing `svn st` as it takes a retarded amount of time when
    the source is cold
    
    Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
    Signed-off-by: Bryan Wu <cooloney@kernel.org>
    Signed-off-by: Sam Ravnborg <sam@ravnborg.org>

diff --git a/scripts/setlocalversion b/scripts/setlocalversion
index f6946cf..f1c4b35 100755
--- a/scripts/setlocalversion
+++ b/scripts/setlocalversion
@@ -58,14 +58,7 @@ fi
 # Check for svn and a svn repo.
 if rev=`svn info 2>/dev/null | grep '^Last Changed Rev'`; then
        rev=`echo $rev | awk '{print $NF}'`
-       changes=`svn status 2>/dev/null | grep '^[AMD]' | wc -l`
-
-       # Are there uncommitted changes?
-       if [ $changes != 0 ]; then
-               printf -- '-svn%s%s' "$rev" -dirty
-       else
-               printf -- '-svn%s' "$rev"
-       fi
+       printf -- '-svn%s' "$rev"
 
        # All done with svn
        exit

I'll do that now.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2013-09-04  9:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-03 14:37 [Buildroot] SVN process started at make Ruud Commandeur
2013-09-03 14:50 ` Peter Korsgaard
2013-09-03 16:28   ` Arnout Vandecappelle
2013-09-04  7:55     ` Ruud Commandeur
2013-09-04  8:07       ` Thomas Petazzoni
2013-09-04  8:57         ` Ruud Commandeur
2013-09-04  9:15           ` Peter Korsgaard [this message]
2013-09-04 10:02             ` Peter Korsgaard
2013-09-04 11:49               ` Ruud Commandeur
2013-09-04 11:26             ` Ruud Commandeur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zjrt3q34.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox