Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ncurses: convert to autotools infrastructure
Date: Mon, 03 May 2010 08:43:53 +0200	[thread overview]
Message-ID: <87zl0heb86.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1272840373-20446-1-git-send-email-llandwerlin@gmail.com> (llandwerlin@gmail.com's message of "Mon, 3 May 2010 00:46:13 +0200")

>>>>> "llandwerlin" == llandwerlin  <llandwerlin@gmail.com> writes:

 llandwerlin> From: Lionel Landwerlin <llandwerlin@gmail.com>
 llandwerlin> Signed-off-by: Lionel Landwerlin <llandwerlin@gmail.com>
 
 llandwerlin>  ifneq ($(BR2_PACKAGE_NCURSES_TARGET_HEADERS),y)
 llandwerlin> -NCURSES_WANT_STATIC=--disable-static
 llandwerlin> +NCURSES_CONF_OPT += --disable-static
 llandwerlin>  endif

Not your fault, but I don't see the relation between headers (which
should use the global BR2_HAVE_DEVFILES instead?) and wanting to be able
to link statically?

Otherwise it looks good - Committed, thanks.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2010-05-03  6:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-30  0:42 [Buildroot] [pull request] ncurses conversion + fix llandwerlin at gmail.com
2010-04-30  0:42 ` [Buildroot] [PATCH 1/2] ncurses: convert to autotools infrastructure llandwerlin at gmail.com
2010-05-01 11:06   ` Thomas Petazzoni
2010-05-01 13:46     ` Lionel Landwerlin
2010-05-02 22:46     ` [Buildroot] [PATCH] " llandwerlin at gmail.com
2010-05-03  6:43       ` Peter Korsgaard [this message]
2010-04-30  0:42 ` [Buildroot] [PATCH 2/2] ncurses: fix path to patch ncurses5-config llandwerlin at gmail.com
2010-05-01 11:07   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zl0heb86.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox